Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Structured Logging migration: modify cri part logs of kubelet. #99006

Merged
merged 1 commit into from Mar 17, 2021
Merged

Structured Logging migration: modify cri part logs of kubelet. #99006

merged 1 commit into from Mar 17, 2021

Conversation

yangjunmyfm192085
Copy link
Contributor

@yangjunmyfm192085 yangjunmyfm192085 commented Feb 11, 2021 •
edited

Signed-off-by: JunYang yang.jun22@zte.com.cn

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Structured Logging migration: modify cri part logs of kubelet.
xref:
https://github.com/kubernetes/enhancements/tree/master/keps/sig-instrumentation/1602-structured-logging
https://github.com/kubernetes/community/blob/master/contributors/devel/sig-instrumentation/migration-to-structured-logging.md

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

part of kubernetes/enhancements#1602
As it is related to log, change the log here to structured log.

Does this PR introduce a user-facing change?

Migrate `pkg/kubelet/(cri)` to structured logging

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[Log migrate]

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 11, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @yangjunmyfm192085. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 11, 2021
@kikisdeliveryservice kikisdeliveryservice added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Feb 11, 2021
@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Feb 11, 2021
@kikisdeliveryservice kikisdeliveryservice added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Feb 11, 2021
@k8s-ci-robot k8s-ci-robot removed the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Feb 11, 2021
@kikisdeliveryservice
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 11, 2021
@kikisdeliveryservice kikisdeliveryservice moved this from Triage to Needs Reviewer in SIG Node PR Triage Feb 11, 2021
@kikisdeliveryservice
Copy link
Member

related enhancement issue: kubernetes/enhancements#1602
related node issue: #98976

ehashman
ehashman reviewed Feb 11, 2021
View reviewed changes
pkg/kubelet/cri/remote/remote_image.go Outdated Show resolved Hide resolved
pkg/kubelet/cri/remote/remote_image.go Outdated Show resolved Hide resolved
@ehashman ehashman moved this from Needs Reviewer to Waiting on Author in SIG Node PR Triage Feb 11, 2021
@ehashman
Copy link
Member

/hold

#98589 migrates the same files and was submitted first

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 11, 2021
@yangjunmyfm192085
Copy link
Contributor Author

/test pull-kubernetes-node-e2e

@yangjunmyfm192085
Copy link
Contributor Author

@ehashman I have completed all modifications,Could you help me take a look? thanks very much.

@ehashman ehashman mentioned this pull request Mar 4, 2021
Closed
ehashman
ehashman reviewed Mar 8, 2021
View reviewed changes
Copy link
Member

@ehashman ehashman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM other than my one comment, which I'm not sure should be blocking.

/lgtm

@ehashman ehashman moved this from Waiting on Author to Needs Approver in SIG Node PR Triage Mar 8, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 8, 2021
@ehashman ehashman moved this from Waiting on Author to Needs Approver in Structured Logging Migration for Kubelet, 1.21 Mar 8, 2021
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 9, 2021
@yangjunmyfm192085
Structured Logging migration: modify cri part logs of kubelet.
024ce9a 
Signed-off-by: JunYang <yang.jun22@zte.com.cn>
ehashman
ehashman reviewed Mar 9, 2021
View reviewed changes
Copy link
Member

@ehashman ehashman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-
/lgtm

@mrunalp is this good?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 9, 2021
@ehashman
Copy link
Member

/milestone v1.21

@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Mar 11, 2021
@mrunalp
Copy link
Contributor

mrunalp commented Mar 16, 2021

/approve

@mrunalp mrunalp moved this from Needs Approver to Done in SIG Node PR Triage Mar 16, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrunalp, yangjunmyfm192085

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 16, 2021
@ehashman ehashman moved this from Needs Approver to Done in Structured Logging Migration for Kubelet, 1.21 Mar 16, 2021
@yangjunmyfm192085
Copy link
Contributor Author

/test pull-kubernetes-unit

@yangjunmyfm192085
Copy link
Contributor Author

/test pull-kubernetes-e2e-kind

2 similar comments
@yangjunmyfm192085
Copy link
Contributor Author

/test pull-kubernetes-e2e-kind

@yangjunmyfm192085
Copy link
Contributor Author

/test pull-kubernetes-e2e-kind

@yangjunmyfm192085
Copy link
Contributor Author

pull-kubernetes-e2e-kind

@pacoxu
Copy link
Member

pacoxu commented Mar 17, 2021

/retest

@k8s-ci-robot k8s-ci-robot merged commit c5680da into kubernetes:master Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrunalp mrunalp mrunalp left review comments

@ehashman ehashman ehashman requested changes

@kikisdeliveryservice kikisdeliveryservice kikisdeliveryservice left review comments

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@krmayankk krmayankk Awaiting requested review from krmayankk

@serathius serathius Awaiting requested review from serathius

Assignees

@ehashman ehashman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node PR Triage
Done
Structured Logging Migration for Kube...
  
Done
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@yangjunmyfm192085 @k8s-ci-robot @kikisdeliveryservice @ehashman @serathius @mrunalp @pacoxu