Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure InstanceShutdownByProviderID return false for creating Azure VMs #104382

Merged
merged 1 commit into from Aug 24, 2021
Merged

fix: ensure InstanceShutdownByProviderID return false for creating Azure VMs #104382

merged 1 commit into from Aug 24, 2021

Conversation

feiskyer
Copy link
Member

What type of PR is this?

/kind bug
/sig cloud-provider
/area provider/azure
/priority critical-urgent

What this PR does / why we need it:

cherry-pick bug fix from out-of-tree cloud provider kubernetes-sigs/cloud-provider-azure#743: ensure InstanceShutdownByProviderID return false for creating Azure VMs.

Which issue(s) this PR fixes:

Fixes kubernetes-sigs/cloud-provider-azure#742

Special notes for your reviewer:

Does this PR introduce a user-facing change?

fix: ensure InstanceShutdownByProviderID return false for creating Azure VMs

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 16, 2021
@feiskyer
Copy link
Member Author

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. area/cloudprovider and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 16, 2021
@feiskyer
Copy link
Member Author

/assign @nilo19 @cheftako

@nilo19
Copy link
Member

nilo19 commented Aug 16, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 16, 2021
This was referenced Aug 19, 2021
Merged
Merged
Merged
Merged
@nilo19
Copy link
Member

nilo19 commented Aug 19, 2021

/lgtm

andrewsykim
andrewsykim reviewed Aug 24, 2021
View reviewed changes
Copy link
Member

@andrewsykim andrewsykim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

(ack that this is a bug fix and not a feature)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewsykim, feiskyer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 24, 2021
@k8s-ci-robot k8s-ci-robot merged commit 625b1e2 into kubernetes:master Aug 24, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Aug 24, 2021
@feiskyer feiskyer deleted the fix-vm-state branch August 24, 2021 05:46
k8s-ci-robot added a commit that referenced this pull request Sep 9, 2021
@k8s-ci-robot
Merge pull request #104449 from feiskyer/automated-cherry-pick-of-#10…
29af011 
…4384-#104382-upstream-release-1.19

Automated cherry pick of #104384: fix: skip case sensitivity when checking Azure NSG rules
#104382: fix: ensure InstanceShutdownByProviderID return false for
k8s-ci-robot added a commit that referenced this pull request Sep 9, 2021
@k8s-ci-robot
Merge pull request #104446 from feiskyer/automated-cherry-pick-of-#10…
c44c96a 
…4384-#104382-upstream-release-1.22

Automated cherry pick of #104384: fix: skip case sensitivity when checking Azure NSG rules
#104382: fix: ensure InstanceShutdownByProviderID return false for
k8s-ci-robot added a commit that referenced this pull request Sep 9, 2021
@k8s-ci-robot
Merge pull request #104448 from feiskyer/automated-cherry-pick-of-#10…
ae81f38 
…4384-#104382-upstream-release-1.20

Automated cherry pick of #104384: fix: skip case sensitivity when checking Azure NSG rules
#104382: fix: ensure InstanceShutdownByProviderID return false for
k8s-ci-robot added a commit that referenced this pull request Sep 9, 2021
@k8s-ci-robot
Merge pull request #104447 from feiskyer/automated-cherry-pick-of-#10…
68b306d 
…4384-#104382-upstream-release-1.21

Automated cherry pick of #104384: fix: skip case sensitivity when checking Azure NSG rules
#104382: fix: ensure InstanceShutdownByProviderID return false for
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cheftako cheftako cheftako left review comments

@andrewsykim andrewsykim andrewsykim left review comments

@aramase aramase Awaiting requested review from aramase

@ritazh ritazh Awaiting requested review from ritazh

Assignees

@cheftako cheftako

@nilo19 nilo19

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cloudprovider area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

VMSS instance with powerstate stopped may be still under creating
5 participants
@feiskyer @nilo19 @k8s-ci-robot @cheftako @andrewsykim