Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate pkg/kubelet/kubelet.go to structured logging #99861

Merged
merged 1 commit into from Mar 18, 2021
Merged

Migrate pkg/kubelet/kubelet.go to structured logging #99861

merged 1 commit into from Mar 18, 2021

Conversation

navidshaikh
Copy link
Member

@navidshaikh navidshaikh commented Mar 5, 2021 •
edited by liggitt

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Migrate pkg/kubelet/kubelet.go to structured logging

Which issue(s) this PR fixes:

part of #98976

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/sig node instrumentation
/priority important-soon

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 5, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @navidshaikh. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. area/kubelet labels Mar 5, 2021
navidshaikh
navidshaikh commented Mar 5, 2021
View reviewed changes
pkg/kubelet/kubelet.go Outdated Show resolved Hide resolved
pkg/kubelet/kubelet.go Outdated Show resolved Hide resolved
pkg/kubelet/kubelet.go Show resolved Hide resolved
pkg/kubelet/kubelet.go Show resolved Hide resolved
pkg/kubelet/kubelet.go Outdated Show resolved Hide resolved
pkg/kubelet/kubelet.go Show resolved Hide resolved
pkg/kubelet/kubelet.go Outdated Show resolved Hide resolved
pkg/kubelet/kubelet.go Show resolved Hide resolved
@navidshaikh
Copy link
Member Author

/cc @ehashman @serathius

ehashman
ehashman reviewed Mar 5, 2021
View reviewed changes
Copy link
Member

@ehashman ehashman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/triage accepted

pkg/kubelet/kubelet.go Outdated Show resolved Hide resolved
pkg/kubelet/kubelet.go Show resolved Hide resolved
pkg/kubelet/kubelet.go Outdated Show resolved Hide resolved
pkg/kubelet/kubelet.go Outdated Show resolved Hide resolved
pkg/kubelet/kubelet.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 5, 2021
@ehashman ehashman added this to Waiting on Author in SIG Node PR Triage Mar 5, 2021
@navidshaikh navidshaikh mentioned this pull request Mar 7, 2021
Merged
navidshaikh
navidshaikh commented Mar 8, 2021
View reviewed changes
pkg/kubelet/kubelet.go Outdated Show resolved Hide resolved
@ehashman ehashman mentioned this pull request Mar 8, 2021
Closed
ehashman
ehashman reviewed Mar 8, 2021
View reviewed changes
Copy link
Member

@ehashman ehashman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

I don't think we should block this PR on the remaining convo.

@ehashman ehashman moved this from Waiting on Author to Needs Approver in SIG Node PR Triage Mar 8, 2021
serathius
serathius reviewed Mar 8, 2021
View reviewed changes
pkg/kubelet/kubelet.go Outdated Show resolved Hide resolved
serathius
serathius reviewed Mar 8, 2021
View reviewed changes
pkg/kubelet/kubelet.go Outdated Show resolved Hide resolved
serathius
serathius reviewed Mar 8, 2021
View reviewed changes
pkg/kubelet/kubelet.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 9, 2021
@serathius
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 9, 2021
@ehashman
Copy link
Member

/milestone v1.21

@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Mar 11, 2021
mrunalp
mrunalp reviewed Mar 16, 2021
View reviewed changes
pkg/kubelet/kubelet.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 17, 2021
@navidshaikh
Copy link
Member Author

/test pull-kubernetes-e2e-kind

@navidshaikh navidshaikh moved this from Needs Approver to Needs Reviewer in Structured Logging Migration for Kubelet, 1.21 Mar 17, 2021
@kikisdeliveryservice
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 17, 2021
@kikisdeliveryservice kikisdeliveryservice moved this from Needs Reviewer to Needs Approver in Structured Logging Migration for Kubelet, 1.21 Mar 17, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrunalp, navidshaikh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 17, 2021
@ehashman
Copy link
Member

/retest

@navidshaikh
Copy link
Member Author

/test pull-kubernetes-e2e-kind-ipv6

@mrunalp mrunalp moved this from Needs Approver to Done in Structured Logging Migration for Kubelet, 1.21 Mar 17, 2021
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit e9632d9 into kubernetes:master Mar 18, 2021
SIG Node PR Triage automation moved this from Needs Approver to Done Mar 18, 2021
@navidshaikh navidshaikh deleted the pr/slog-kubelet branch March 18, 2021 04:01
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehashman ehashman ehashman left review comments

@serathius serathius serathius left review comments

@mrunalp mrunalp mrunalp approved these changes

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@yifan-gu yifan-gu Awaiting requested review from yifan-gu

Assignees

@ehashman ehashman

@serathius serathius

@kikisdeliveryservice kikisdeliveryservice

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/node Categorizes an issue or PR as relevant to SIG Node. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node PR Triage
Done
Structured Logging Migration for Kube...
  
Done
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@navidshaikh @k8s-ci-robot @serathius @ehashman @kikisdeliveryservice @fejta-bot @mrunalp