Bug 1920221: Allow test invokers to skip test waits before and after #98781
Conversation
A number of e2e tests are useful to run after the system has been disrupted or is in the progress of being disrupted, but the current suite and test logic blocks progress waiting for all nodes to be healthy. By passing -1 to --minStartupPods or --allowed-not-ready-nodes flags the caller can bypass wait logic before and after test suites that would prevent running e2e during disruption. This allows use of parts of the e2e suite during cluster duress to verify that controllers or components still function.
k8s-ci-robot
added
release-note
|
@smarterclayton: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
do-not-merge/needs-sig
k8s-ci-robot
added
area/e2e-test-framework
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: smarterclayton The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/retest |
1 similar comment
|
/retest |
smarterclayton
changed the title
|
/retest |
|
controlled skips of preflights makes sense and doesn't impact callers making use of them. /lgtm |
k8s-ci-robot
added
the
lgtm
A number of e2e tests are useful to run after the system has been disrupted or is in the progress of being disrupted, but the current
suite and test logic blocks progress waiting for all nodes to be healthy.
By passing -1 to --minStartupPods or --allowed-not-ready-nodes flags the caller can bypass wait logic before and after test suites that would prevent running e2e during disruption. This allows use of parts of the e2e suite during cluster duress to verify that controllers or components still function.
A specific example of this includes testing clusters that have a number of nodes marked unschedulable or not ready and verifying that the system still functions.
In general, some of the hardcoded waits won't make sense on all Kube distributions anyway (those without pods in kube-system), so bypassing may be useful for others who wrap e2e with their own logic. A caller should not have to have pods in kube-system to be conformant, for example.
This should not impact any existing callers of these APIs since previously -1 would fail or wait forever.
/kind cleanup