New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
batch API: add suspended job #98727
batch API: add suspended job #98727
Conversation
/sig apps |
2ac0991
to
952aef4
Compare
This PR may require API review. If so, when the changes are ready, complete the pre-review checklist and request an API review. Status of requested reviews is tracked in the API Review project. |
pkg/controller/job/job_controller.go
Outdated
sort.Sort(controller.ActivePods(activePods)) | ||
|
||
active -= diff | ||
deletePods := func(numPodsToDelete int32) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have refactored this into its own function :)
But I can resolve the conflicts later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
addressed all but two comments, I'll respond to those shortly
@adtac I think we are good to squash |
ack, squashed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold cancel |
/lgtm |
Signed-off-by: Adhityaa Chandrasekar <adtac@google.com>
/lgtm |
for future reference: keeping this unsquashed was fine |
/retest |
@adtac: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest |
What type of PR is this?
/kind feature
/kind api-change
What this PR does / why we need it: See KEP: kubernetes/enhancements#2234
Which issue(s) this PR fixes:
Part of kubernetes/enhancements#2232
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
cc @ahg-g @alculquicondor @soltysh