Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #94087: node sync at least once #97996

Merged
merged 2 commits into from Feb 12, 2021
Merged

Automated cherry pick of #94087: node sync at least once #97996

merged 2 commits into from Feb 12, 2021

Conversation

ehashman
Copy link
Member

@ehashman ehashman commented Jan 13, 2021 •
edited

Cherry pick of #94087 on release-1.19.

#94087: node sync at least once

For details on the cherry pick process, see the cherry pick requests page.

Avoid marking node as Ready until node has synced with API servers at least once

@k8s-ci-robot k8s-ci-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Jan 13, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Jan 13, 2021
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 13, 2021
@ehashman ehashman changed the title Automated cherry pick of #94087: WIP: node sync at least once Automated cherry pick of #94087: node sync at least once Jan 13, 2021
@ehashman
Copy link
Member Author

/release-note-none
/kind bug
/priority important-soon

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 13, 2021
@ehashman
Copy link
Member Author

/retest

@ehashman ehashman added this to Needs Reviewer in SIG Node PR Triage Jan 14, 2021
@ehashman
Copy link
Member Author

/hold

If we take this patch, we should also take #98137 with it to avoid introducing logspam.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 19, 2021
@liggitt
Copy link
Member

liggitt commented Jan 20, 2021

If we take this patch, we should also take #98137 with it to avoid introducing logspam.

+1. Can you pick that commit into this PR as well?

@karan
Copy link
Contributor

karan commented Jan 20, 2021

/cc @karan

@chymy @ehashman
kubelet logs print 'kubelet nodes sync' frequently
6b84672 
Signed-off-by: chymy <chang.min1@zte.com.cn>
@ehashman
Copy link
Member Author

/hold cancel

@liggitt done :)

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 20, 2021
@liggitt
Copy link
Member

liggitt commented Jan 25, 2021

thanks, can someone from the node team review this?

@ehashman
Copy link
Member Author

/triage accepted
/assign @mrunalp

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 25, 2021
@alculquicondor
Copy link
Member

can we add a release note?

@ehashman
Copy link
Member Author

@alculquicondor there was no release note on master, what do you want to see in the cherry-picks?

@alculquicondor
Copy link
Member

alculquicondor commented Feb 11, 2021 •
edited

Something along the lines:

Fixed race condition in kubelet where it sometimes misses node updates

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Feb 11, 2021
@ehashman
Copy link
Member Author

Done.

@sjenning
Copy link
Contributor

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 12, 2021
hasheddan
hasheddan approved these changes Feb 12, 2021
View reviewed changes
Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ehashman, hasheddan, sjenning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 12, 2021
@ehashman ehashman moved this from Needs Reviewer to Done in SIG Node PR Triage Feb 12, 2021
@hasheddan hasheddan added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Feb 12, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Feb 12, 2021
@kikisdeliveryservice
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit c337677 into kubernetes:release-1.19 Feb 12, 2021
@liggitt liggitt mentioned this pull request Feb 25, 2021
Closed
@imharshita
Copy link

/close

fixed in #94087
Details: #93338

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasheddan hasheddan hasheddan approved these changes

@mattjmcnaughton mattjmcnaughton Awaiting requested review from mattjmcnaughton

@mtaufen mtaufen Awaiting requested review from mtaufen

@karan karan Awaiting requested review from karan

Assignees

@mrunalp mrunalp

@kikisdeliveryservice kikisdeliveryservice

@hasheddan hasheddan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node PR Triage
Done
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

None yet