Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #99464: Number of sockets is assumed to be same as NUMA nodes #99771

Merged
merged 1 commit into from Mar 13, 2021
Merged

Automated cherry pick of #99464: Number of sockets is assumed to be same as NUMA nodes #99771

merged 1 commit into from Mar 13, 2021

Conversation

iwankgb
Copy link
Contributor

@iwankgb iwankgb commented Mar 4, 2021 •
edited by liggitt

Cherry pick of #99464 on release-1.19.

#99464: Number of sockets is assumed to be same as NUMA nodes

For details on the cherry pick process, see the cherry pick requests page.

Fixes a regression in 1.19+ to make kubelet retrieve number of sockets from cAdvisor MachineInfo, instead of assuming it to be equal to number of NUMA nodes.

@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Mar 4, 2021
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 4, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @iwankgb. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/kubelet labels Mar 4, 2021
@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 4, 2021
@iwankgb
Copy link
Contributor Author

iwankgb commented Mar 4, 2021

/sig node
/kind bug

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Mar 4, 2021
@ehashman ehashman added this to Triage in SIG Node PR Triage Mar 4, 2021
@troy0820
Copy link
Member

troy0820 commented Mar 9, 2021

/priority important-soon
/triage accepted

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 9, 2021
@troy0820
Copy link
Member

troy0820 commented Mar 9, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Mar 9, 2021
@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 9, 2021
@troy0820 troy0820 moved this from Triage to Needs Reviewer in SIG Node PR Triage Mar 9, 2021
@bobbypage
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 10, 2021
@klueska
Copy link
Contributor

klueska commented Mar 11, 2021

Just to be sure. Does v1.19 have the version of cadvisor where this is relevant? What version of cadvisor did this staartz to be required, and what version of cadvisor is v1.19 on?

@iwankgb
Copy link
Contributor Author

iwankgb commented Mar 11, 2021

@klueska this is PR introducing related changes in cAdvisor to 1.19: #99209.

@klueska
Copy link
Contributor

klueska commented Mar 11, 2021

OK, so we should wait for that to merge first then.

/approve
/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 11, 2021
@ehashman ehashman moved this from Needs Reviewer to Needs Approver in SIG Node PR Triage Mar 12, 2021
@ehashman ehashman moved this from Needs Approver to Done in SIG Node PR Triage Mar 12, 2021
hasheddan
hasheddan approved these changes Mar 12, 2021
View reviewed changes
Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hasheddan, iwankgb, klueska

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hasheddan
Copy link
Contributor

CP approval pending tests passing on #99493

@hasheddan hasheddan added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 12, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Mar 12, 2021
@bobbypage
Copy link
Member

#99209 has merged, so removing hold from #99771 (comment)

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 13, 2021
@iwankgb
Copy link
Contributor Author

iwankgb commented Mar 13, 2021

/test pull-kubernetes-e2e-kind

@k8s-ci-robot k8s-ci-robot merged commit f8ec7f5 into kubernetes:release-1.19 Mar 13, 2021
@iwankgb iwankgb deleted the automated-cherry-pick-of-#99464-upstream-release-1.19 branch March 13, 2021 09:47
@liggitt liggitt added the kind/regression Categorizes issue or PR as related to a regression from a prior release. label Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasheddan hasheddan hasheddan approved these changes

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@klueska klueska Awaiting requested review from klueska

Assignees

@bobbypage bobbypage

@hasheddan hasheddan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/regression Categorizes issue or PR as related to a regression from a prior release. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node PR Triage
Done
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@iwankgb @k8s-ci-robot @troy0820 @bobbypage @klueska @hasheddan @liggitt