Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove WindowsGMSA and WindowsRunAsUserName feature gates #96531

Merged
merged 1 commit into from Jan 30, 2021
Merged

Remove WindowsGMSA and WindowsRunAsUserName feature gates #96531

merged 1 commit into from Jan 30, 2021

Conversation

ialidzhikov
Copy link
Contributor

@ialidzhikov ialidzhikov commented Nov 12, 2020 •
edited

What type of PR is this?
/kind cleanup

Which issue(s) this PR fixes:

Fixes #95707

Does this PR introduce a user-facing change?:

The feature gates `WindowsGMSA` and `WindowsRunAsUserName` that are GA since v1.18 are now removed.

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 12, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @ialidzhikov. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 12, 2020
@k8s-ci-robot k8s-ci-robot added area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 12, 2020
@ialidzhikov
Copy link
Contributor Author

/cc @marosset

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Nov 12, 2020
@ialidzhikov
Copy link
Contributor Author

/sig windows

@k8s-ci-robot k8s-ci-robot added the sig/windows Categorizes an issue or PR as relevant to SIG Windows. label Nov 12, 2020
@marosset
Copy link
Contributor

There is another PR already open for this #95834

@marosset
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 12, 2020
@ialidzhikov
Copy link
Contributor Author

/test pull-kubernetes-e2e-gce-ubuntu-containerd
/test pull-kubernetes-e2e-gce-alpha-features

@ialidzhikov
Copy link
Contributor Author

@marosset , the required checks now passed.

@ialidzhikov
Copy link
Contributor Author

ialidzhikov commented Nov 13, 2020 •
edited

ping @marosset

@marosset
Copy link
Contributor

Hi @ialidzhikov - as I mentioned above we have another contributor who has already opened a PR to address this and I want to give them a chance to get their changes merged. Thanks!

@ehashman ehashman added this to Needs Reviewer in SIG Node PR Triage Jan 6, 2021
@vpnachev
Copy link
Contributor

Hello @marosset
I see the other PR has already been closed #95834 and another opened to replace it #96653, but it is still open and seems there were no activity in the last 2 months #96653 (comment).

Then how about merging this one which is ready and have waited enough time?

@ehashman
Copy link
Member

/priority important-soon

ref KEP kubernetes/enhancements#689

@k8s-ci-robot k8s-ci-robot added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Jan 26, 2021
@ehashman
Copy link
Member

/assign @dchen1107 @derekwaynecarr

@ehashman
Copy link
Member

I think that's a flaky test (#98084).

/retest

@marosset
Copy link
Contributor

marosset commented Jan 26, 2021 •
edited

Yes this a flaky test :(
It shouldn't be PR blocking tho - just informing.

@jsturtevant jsturtevant mentioned this pull request Jan 28, 2021
Closed
@ehashman ehashman mentioned this pull request Jan 28, 2021
Closed
@mrunalp
Copy link
Contributor

mrunalp commented Jan 29, 2021

/approve

@marosset
Copy link
Contributor

@dims, @dchen1107, @derekwaynecarr Could one of you give feature-approvers approval here?

It looks like no-one from SIG-Windows is on the list after m2 left

kubernetes/OWNERS_ALIASES

Line 556 in df7f240

feature-approvers:

@dims
Copy link
Member

dims commented Jan 29, 2021

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, ialidzhikov, mrunalp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 29, 2021
@ehashman
Copy link
Member

@ialidzhikov can you please rebase? looks like there's been another conflict merged

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 29, 2021
@ehashman ehashman moved this from Needs Approver to Waiting on Author in SIG Node PR Triage Jan 29, 2021
@ialidzhikov
Remove WindowsGMSA and WindowsRunAsUserName feature gates
21608e4 
Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 30, 2021
ehashman
ehashman reviewed Jan 30, 2021
View reviewed changes
Copy link
Member

@ehashman ehashman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 30, 2021
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

1 similar comment
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 197dbac into kubernetes:master Jan 30, 2021
SIG-Windows automation moved this from Reviewed - Needs Approval From Other SIGs to Done (v1.21) Jan 30, 2021
SIG Node PR Triage automation moved this from Waiting on Author to Done Jan 30, 2021
@github-actions github-actions bot mentioned this pull request Feb 3, 2021
Open
@dims dims mentioned this pull request Apr 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehashman ehashman ehashman left review comments

@lavalamp lavalamp Awaiting requested review from lavalamp

@vishh vishh Awaiting requested review from vishh

@marosset marosset Awaiting requested review from marosset

@wk8 wk8 Awaiting requested review from wk8

Assignees

@ehashman ehashman

@derekwaynecarr derekwaynecarr

@dchen1107 dchen1107

@marosset marosset

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/backlog Higher priority than priority/awaiting-more-evidence. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node PR Triage
Done
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

Remove WindowsGMSA and WindowsRunAsUserName feature gates in 1.20
10 participants
@ialidzhikov @k8s-ci-robot @marosset @vpnachev @ehashman @mrunalp @dims @fejta-bot @derekwaynecarr @dchen1107