Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the deprecated metrics from scheduler #96447

Merged
merged 1 commit into from Dec 14, 2020
Merged

Remove the deprecated metrics from scheduler #96447

merged 1 commit into from Dec 14, 2020

Conversation

chendave
Copy link
Member

@chendave chendave commented Nov 11, 2020 •
edited

metrics data is not exactly the same due to the different code path, here is a sample collected from BenchmarkPerfScheduling/Preemption/500Nodes after #96258 get merged.

indicator scheduler_binding_duration_seconds scheduler_framework_extension_point_duration_seconds/Bind
Average (ms) 2.145300516800011 2.1417367068000033
Perc50 (ms) 1.4517583408476107 1.3645197740112995
Perc90 (ms) 5.7379310344827585 5.611111111111112
Perc99 (ms) 7.462068965517242 8.469461077844311

What type of PR is this?
/kind feature

Depends: #96258

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Remove the deprecated metrics "scheduling_algorithm_preemption_evaluation_seconds" and "binding_duration_seconds", suggest to use "scheduler_framework_extension_point_duration_seconds" instead.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 11, 2020
@chendave
Copy link
Member Author

/hold for #96258

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. area/test sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 11, 2020
@chendave
Copy link
Member Author

not sure whether a release not should be added for the change like this, I'd happy to remove it if this is not necessary.

@chendave
Copy link
Member Author

/test pull-kubernetes-e2e-gce-ubuntu-containerd
/test pull-kubernetes-conformance-kind-ipv6-parallel

@chendave
Copy link
Member Author

/cc @adtac

@chendave chendave mentioned this pull request Nov 11, 2020
Closed
@adtac
Copy link
Member

adtac commented Nov 11, 2020

/assign

will take a look in a bit

@fedebongio
Copy link
Contributor

/remove-sig api-machinery
/cc @logicalhan

@k8s-ci-robot k8s-ci-robot removed the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Nov 12, 2020
@ehashman
Copy link
Member

ehashman commented Dec 2, 2020

/assign @RainbowMango @logicalhan
/triage accepted

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 14, 2020
@chendave
Copy link
Member Author

/remove-kind feature
/kind cleanup

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed kind/feature Categorizes issue or PR as related to a new feature. labels Dec 14, 2020
@chendave
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 14, 2020
@chendave
Copy link
Member Author

Please split the commit deprecating the preemption metric into separate PR.

Done

@chendave chendave changed the title Fetch metrics data from scheduler extension point Remove the deprecated metrics from scheduler Dec 14, 2020
@chendave @wawa0210
Remove the deprecated metrics from scheduler
5144e2e 
Deprecated metrics are removed and suggest to use the Histogram
metrics got from scheduler extension points.

Signed-off-by: Dave Chen <dave.chen@arm.com>
Co-authored-by: wawa0210 <xiaozhang0210@hotmail.com>
@chendave
Copy link
Member Author

/cc @wawa0210 for review.

@wawa0210
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 14, 2020
@ahg-g
Copy link
Member

ahg-g commented Dec 14, 2020

/kind deprecation

@k8s-ci-robot k8s-ci-robot added the kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. label Dec 14, 2020
@ahg-g
Copy link
Member

ahg-g commented Dec 14, 2020

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, chendave, wawa0210

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 14, 2020
@k8s-ci-robot k8s-ci-robot merged commit bd4d197 into kubernetes:master Dec 14, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Dec 14, 2020
@github-actions github-actions bot mentioned this pull request Dec 16, 2020
Open
swiatekm-sumo added a commit to SumoLogic/sumologic-kubernetes-collection that referenced this pull request Jan 21, 2022
@swiatekm-sumo
feat: export scheduler_framework_extension_point_duration metrics
30ea63f 
scheduler_binding_duration is deprected in Kubernetes 1.21 and the
generic framework extension metrics are the replacements.
See: kubernetes/kubernetes#96447
@swiatekm-sumo swiatekm-sumo mentioned this pull request Jan 21, 2022
Merged
1 task
swiatekm-sumo added a commit to SumoLogic/sumologic-kubernetes-collection that referenced this pull request Jan 21, 2022
@swiatekm-sumo
feat: export scheduler_framework_extension_point_duration metrics
d3a23fe 
scheduler_binding_duration is deprected in Kubernetes 1.21 and the
generic framework extension metrics are the replacements.
See: kubernetes/kubernetes#96447
swiatekm-sumo added a commit to SumoLogic/sumologic-kubernetes-collection that referenced this pull request Jan 21, 2022
@swiatekm-sumo
feat: export scheduler_framework_extension_point_duration metrics
4c0c6b2 
scheduler_binding_duration is deprected in Kubernetes 1.21 and the
generic framework extension metrics are the replacements.
See: kubernetes/kubernetes#96447
swiatekm-sumo added a commit to SumoLogic/sumologic-kubernetes-collection that referenced this pull request Jan 24, 2022
@swiatekm-sumo
feat: export scheduler_framework_extension_point_duration metrics
a23b76f 
scheduler_binding_duration is deprected in Kubernetes 1.21 and the
generic framework extension metrics are the replacements.
See: kubernetes/kubernetes#96447
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahg-g ahg-g Awaiting requested review from ahg-g

@andyxning andyxning Awaiting requested review from andyxning

@adtac adtac Awaiting requested review from adtac

@logicalhan logicalhan Awaiting requested review from logicalhan

Assignees

@logicalhan logicalhan

@adtac adtac

@wawa0210 wawa0210

@RainbowMango RainbowMango

@ahg-g ahg-g

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@chendave @adtac @fedebongio @ehashman @ahg-g @wawa0210 @k8s-ci-robot @logicalhan @RainbowMango