Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ignore the case when comparing azure tags in service annotation #104705

Merged
merged 1 commit into from Sep 3, 2021
Merged

fix: ignore the case when comparing azure tags in service annotation #104705

merged 1 commit into from Sep 3, 2021

Conversation

nilo19
Copy link
Member

@nilo19 nilo19 commented Sep 1, 2021

What type of PR is this?

/kind bug

What this PR does / why we need it:

fix: ignore the case when comparing azure tags in service annotation

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

fix: ignore the case when comparing azure tags in service annotation

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/triage accepted
/sig cloud-provider
/area provider/azure
/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. triage/accepted Indicates an issue or PR is ready to be actively worked on. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Sep 1, 2021
@nilo19
Copy link
Member Author

nilo19 commented Sep 1, 2021

/retest

2 similar comments
@CecileRobertMichon
Copy link
Member

/retest

@nilo19
Copy link
Member Author

nilo19 commented Sep 2, 2021

/retest

@feiskyer feiskyer mentioned this pull request Sep 2, 2021
Closed
@nilo19 nilo19 mentioned this pull request Sep 2, 2021
Merged
feiskyer
feiskyer approved these changes Sep 2, 2021
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 2, 2021
@nilo19
Copy link
Member Author

nilo19 commented Sep 2, 2021

/assign @cheftako

@feiskyer
Copy link
Member

feiskyer commented Sep 2, 2021

/assign @andrewsykim

@nilo19 nilo19 mentioned this pull request Sep 3, 2021
Closed
@cheftako
Copy link
Member

cheftako commented Sep 3, 2021

Approved #104734 before I ran across this. Please let me know if you feel this should be merged instead.

@nilo19
Copy link
Member Author

nilo19 commented Sep 3, 2021

@cheftako please merge this one, thanks!

@cheftako
Copy link
Member

cheftako commented Sep 3, 2021

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheftako, feiskyer, nilo19

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 3, 2021
@k8s-ci-robot k8s-ci-robot merged commit 8d43aa6 into kubernetes:master Sep 3, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Sep 3, 2021
@nilo19 nilo19 deleted the bug/ensure-pip-tagged branch September 5, 2021 01:42
@nilo19 nilo19 mentioned this pull request Jan 15, 2022
Merged
k8s-ci-robot added a commit that referenced this pull request Jan 26, 2022
@k8s-ci-robot
Merge pull request #107580 from nilo19/automated-cherry-pick-of-#1061…
de17b6f 
…64-upstream-release-1.22

Cherry pick of #106164 and #104705 on release-1.22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer feiskyer approved these changes

@khenidak khenidak Awaiting requested review from khenidak

@ritazh ritazh Awaiting requested review from ritazh

Assignees

@feiskyer feiskyer

@cheftako cheftako

@andrewsykim andrewsykim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cloudprovider area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@nilo19 @CecileRobertMichon @feiskyer @cheftako @k8s-ci-robot @andrewsykim