Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #105666: fix: skip instance not found when decoupling vmss from lb #105836

Merged
merged 1 commit into from Dec 10, 2021
Merged

Automated cherry pick of #105666: fix: skip instance not found when decoupling vmss from lb #105836

merged 1 commit into from Dec 10, 2021

Conversation

nilo19
Copy link
Member

@nilo19 nilo19 commented Oct 22, 2021 •
edited

Cherry pick of #105666 on release-1.22.

#105666: fix: skip instance not found when decoupling vmss from lb

For details on the cherry pick process, see the cherry pick requests page.

fix: skip instance not found when decoupling vmss from lb

@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Oct 22, 2021
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Oct 22, 2021
@nilo19
Copy link
Member Author

nilo19 commented Oct 22, 2021

/sig cloud-provider
/area provider/azure
/triage accepted
/priority critical-urgent
/kind bug
cc @feiskyer

@k8s-ci-robot k8s-ci-robot added sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. area/provider/azure Issues or PRs related to azure provider triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. kind/bug Categorizes issue or PR as related to a bug. area/cloudprovider and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Oct 22, 2021
@nilo19
Copy link
Member Author

nilo19 commented Oct 22, 2021

/retest

1 similar comment
@nilo19
Copy link
Member Author

nilo19 commented Oct 24, 2021

/retest

feiskyer
feiskyer approved these changes Oct 25, 2021
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 25, 2021
@bridgetkromhout
Copy link
Member

/assign @cheftako

@cheftako
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheftako, feiskyer, nilo19

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 16, 2021
@bridgetkromhout
Copy link
Member

@kubernetes/release-managers please review this cherry-pick request for 1.22 - thanks!

@puerco
Copy link
Member

puerco commented Dec 9, 2021

Thanks @nilo19 !
/lgtm

@puerco puerco added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Dec 9, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Dec 9, 2021
@k8s-ci-robot k8s-ci-robot merged commit ebe30df into kubernetes:release-1.22 Dec 10, 2021
@nilo19 nilo19 deleted the automated-cherry-pick-of-#105666-upstream-release-1.22 branch December 10, 2021 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer feiskyer approved these changes

@brendandburns brendandburns Awaiting requested review from brendandburns

@khenidak khenidak Awaiting requested review from khenidak

Assignees

@feiskyer feiskyer

@cheftako cheftako

@puerco puerco

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cloudprovider area/provider/azure Issues or PRs related to azure provider cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@nilo19 @bridgetkromhout @cheftako @k8s-ci-robot @puerco @feiskyer