Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #107763: e2e: Wait for kube-root-ca.crt to be created #108860

Merged
merged 2 commits into from Mar 22, 2022
Merged

Automated cherry pick of #107763: e2e: Wait for kube-root-ca.crt to be created #108860

merged 2 commits into from Mar 22, 2022

Conversation

eddiezane
Copy link
Member

@eddiezane eddiezane commented Mar 21, 2022 •
edited

Cherry pick of #107763 on release-1.23.

#107763: e2e: Wait for kube-root-ca.crt to be created

For details on the cherry pick process, see the cherry pick requests page.

e2e tests wait for kube-root-ca.crt to be populated in namespaces for use with projected service account tokens, reducing delays starting those test pods and errors in the logs.

@smarterclayton @eddiezane
e2e: Wait for kube-root-ca.crt to be created
a62ee8e 
The change from service account secrets to projected tokens and
the new dependency on kube-root-ca.crt to start pods with those
projected tokens means that e2e tests can start before
kube-root-ca.crt is created in a namespace. Wait for the default
service account AND the kube-root-ca.crt configmap in normal
e2e tests.
@smarterclayton @eddiezane
e2e: Wait only for the service account
3194c87 
Now that projected service account tokens do not require the secret
to be created, exclude the wait condition on the token and simply
wait for the service account.
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Mar 21, 2022
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 21, 2022
@k8s-ci-robot
Copy link
Contributor

@eddiezane: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 21, 2022
@k8s-ci-robot k8s-ci-robot added area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 21, 2022
@eddiezane
Copy link
Member Author

This cherry pick fixes #108307.

The failing test is a skew test that tests older releases of Kubernetes against master. Kubernetes 1.24 no longer auto mounts the default service account token. The 1.23 test waited for the default service account token to be mounted (https://github.com/kubernetes/kubernetes/pull/107763/files#diff-9dcbb8eba12c61d6f3dde188c0b8d8332365139e5062995d322795e02710fb6cL312).

The version marker https://storage.googleapis.com/k8s-release-dev/ci/k8s-stable1.txt will need to be updated before this passes.

/assign @puerco
/assign @liggitt

cc @kubernetes/release-managers @jimangel @kubernetes/ci-signal

@eddiezane
Copy link
Member Author

/kind bug

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Mar 21, 2022
@puerco
Copy link
Member

puerco commented Mar 21, 2022

Thanks a lot @eddiezane 👍
/lgtm

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Mar 21, 2022
@puerco puerco added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 21, 2022
@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Mar 21, 2022
@liggitt
Copy link
Member

liggitt commented Mar 22, 2022

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eddiezane, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 22, 2022
@k8s-ci-robot k8s-ci-robot merged commit 612130d into kubernetes:release-1.23 Mar 22, 2022
@eddiezane eddiezane deleted the automated-cherry-pick-of-#107763-upstream-release-1.23 branch March 22, 2022 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SataQiu SataQiu Awaiting requested review from SataQiu

@timothysc timothysc Awaiting requested review from timothysc

Assignees

@liggitt liggitt

@puerco puerco

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/test cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@eddiezane @k8s-ci-robot @puerco @liggitt @smarterclayton