Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #103154: Update mounter interface in volume manager #106553

Merged
merged 1 commit into from Dec 1, 2021
Merged

Automated cherry pick of #103154: Update mounter interface in volume manager #106553

merged 1 commit into from Dec 1, 2021

Conversation

jsafrane
Copy link
Member

@jsafrane jsafrane commented Nov 19, 2021 •
edited

Cherry pick of #103154 on release-1.21.

#103154: Update mounter interface in volume manager

For details on the cherry pick process, see the cherry pick requests page.

Fixed SELinux relabeling of CSI volumes after CSI driver failure.

Kubernetes 1.22 already has the fix.

@jsafrane
Update mounter interface in volume manager
a458411 
Update mounter interface in volume manager's ActualStateOfWorld every time.
Otherwise kubelet uses the first mounter it gets, which may not have the
latest information.

This fixes set up of CSI volumes, which store information about SELinux
support in their `mounter` interface implementation. With each MountVolume()
retry, a new mounter is instantiated and only the final mounter that succeeds
has the right info if the volume supports SELinux or not and can later
return the right attributes on GetAttributes() call.
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Nov 19, 2021
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 19, 2021
@jsafrane jsafrane force-pushed the automated-cherry-pick-of-#103154-upstream-release-1.21 branch from 1fd0fd8 to a458411 Compare November 19, 2021 13:13
@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 19, 2021
@k8s-ci-robot k8s-ci-robot added area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 19, 2021
@jsafrane
Copy link
Member Author

/sig storage
/priority important-soon
/triage accepted

@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 19, 2021
@openshift-ci-robot openshift-ci-robot mentioned this pull request Nov 19, 2021
Merged
@jsafrane
Copy link
Member Author

/kind bug

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Nov 19, 2021
@jsafrane
Copy link
Member Author

/retests
TestCertRotationContinuousRequests flaked

@tsmetana
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 19, 2021
@jsafrane
Copy link
Member Author

/retest

@jsafrane
Copy link
Member Author

ping @kubernetes/release-managers, PTAL
(reminder: this is already fixed in 1.22)

@ehashman ehashman moved this from Triage to Done in SIG Node PR Triage Nov 24, 2021
@xmudrii
Copy link
Member

xmudrii commented Nov 30, 2021

For some reason, the release note was not inherited from the master PR. Can you please update the PR description to add the release note?

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Dec 1, 2021
@jsafrane
Copy link
Member Author

jsafrane commented Dec 1, 2021

@xmudrii, release note updated

xmudrii
xmudrii approved these changes Dec 1, 2021
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@xmudrii xmudrii added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Dec 1, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Dec 1, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 0ae3625 into kubernetes:release-1.21 Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii approved these changes

@rootfs rootfs Awaiting requested review from rootfs

@verult verult Awaiting requested review from verult

Assignees

@tsmetana tsmetana

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node PR Triage
Done
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jsafrane @tsmetana @xmudrii @k8s-ci-robot