Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct the feature gate string for RBD migration. #107554

Merged
merged 1 commit into from Jan 14, 2022
Merged

Correct the feature gate string for RBD migration. #107554

merged 1 commit into from Jan 14, 2022

Conversation

humblec
Copy link
Contributor

@humblec humblec commented Jan 14, 2022 •
edited

The feature gate is wrongly mentioned as csiMigrationRBD in
kube features where it should have been CSIMigrationRBD to
match other migration feature gates and formatting.

Signed-off-by: Humble Chirammal hchiramm@redhat.com

/kind bug

/kind regression
-->

-->

The feature gate was mentioned as `csiMigrationRBD` where it should have been `CSIMigrationRBD` to be in parity with other migration plugins. This release correct the same and keep it as `CSIMigrationRBD`.

Action Required: users who have configured this feature gate as `csiMigrationRBD` has to reconfigure the same to `CSIMigrationRBD` from this release.

@humblec
Correct the feature gate string for RBD migration.
5f2f540 
The feature gate is wrongly mentioned as csiMigrationRBD in
kube features where it should have been CSIMigrationRBD to
match other migration feature gates and formatting.

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/regression Categorizes issue or PR as related to a regression from a prior release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 14, 2022
@humblec
Copy link
Contributor Author

humblec commented Jan 14, 2022

/sig storage

@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 14, 2022
@k8s-ci-robot
Copy link
Contributor

@humblec: The label(s) priority/important, priority/soon cannot be applied, because the repository doesn't have them.

In response to this:

/priority important soon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@humblec humblec mentioned this pull request Jan 14, 2022
Open
@humblec
Copy link
Contributor Author

humblec commented Jan 14, 2022

/assign @Jiawei0227
/assign @msau42

@dims
Copy link
Member

dims commented Jan 14, 2022

/approve
/lgtm

NOTES: looked at https://cs.k8s.io/?q=CSIMigrationRBD&i=fosho&files=&excludeFiles=&repos= and this definitely we should take care of quickly!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 14, 2022
@dims
Copy link
Member

dims commented Jan 14, 2022

/priority important-soon
/triage accepted

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 14, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, humblec

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 14, 2022
@Jiawei0227
Copy link
Contributor

/lgtm

@humblec humblec mentioned this pull request Jan 14, 2022
Merged
@humblec
Copy link
Contributor Author

humblec commented Jan 14, 2022

/test pull-kubernetes-node-e2e-containerd

@humblec
Copy link
Contributor Author

humblec commented Jan 14, 2022

/test pull-kubernetes-conformance-kind-ga-only-parallel

@k8s-ci-robot k8s-ci-robot merged commit 6f896de into kubernetes:master Jan 14, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Jan 14, 2022
k8s-ci-robot added a commit that referenced this pull request Jan 14, 2022
@k8s-ci-robot
Merge pull request #107555 from humblec/automated-cherry-pick-of-#107…
33f4e42 
…554-upstream-release-1.23

Automated cherry pick of #107554: Correct the feature gate string for RBD migration.
@msau42
Copy link
Member

msau42 commented Jan 14, 2022

@humblec Can you update the release note with an "ACTION REQUIRED" and be more specific about the feature gate naming change?

k8s-ci-robot pushed a commit that referenced this pull request Jan 14, 2022
@msau42
Revert "Automated cherry pick of #107554: Correct the feature gate st…
65b309c 
…ring for RBD migration."
k8s-ci-robot added a commit that referenced this pull request Jan 14, 2022
@k8s-ci-robot
Merge pull request #107571 from msau42/revert-107555-automated-cherry…
d4dec26 
…-pick-of-#107554-upstream-release-1.23

Revert "Automated cherry pick of #107554: Correct the feature gate string for RBD migration."
@humblec humblec mentioned this pull request Jan 17, 2022
Closed
@k8s-ci-robot k8s-ci-robot added release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jan 17, 2022
@humblec humblec mentioned this pull request Jan 17, 2022
Merged
@sftim
Copy link
Contributor

sftim commented Feb 2, 2022

A nit for the changelog entry:

- Action Required: users who have configured this feature gate as `csiMigrationRBD` has to reconfigure the same to `CSIMigrationRBD` from this release.
+ Action Required: cluster operators who have configured this feature gate as `csiMigrationRBD` must switch to using the corrected feature gate name `CSIMigrationRBD` from this release.

or similar. “has to” is not idiomatic English grammar here.

@sftim
Copy link
Contributor

sftim commented May 15, 2022

Relevant to #107488 (comment)

This change needs docs - https://kubernetes.io/docs/reference/command-line-tools-reference/feature-gates/ is not yet up to date as far as I can tell.

@wilsonehusin wilsonehusin mentioned this pull request May 24, 2022
Closed
@liggitt liggitt removed the kind/regression Categorizes issue or PR as related to a regression from a prior release. label Sep 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lavalamp lavalamp Awaiting requested review from lavalamp

@thockin thockin Awaiting requested review from thockin

Assignees

@dims dims

@Jiawei0227 Jiawei0227

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@humblec @k8s-ci-robot @dims @Jiawei0227 @msau42 @sftim @liggitt