Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #97764 upstream release 1.19: ignore cgroup driver check in windows node upgrade #98385

Merged
merged 1 commit into from Jan 27, 2021
Merged

Automated cherry pick of #97764 upstream release 1.19: ignore cgroup driver check in windows node upgrade #98385

merged 1 commit into from Jan 27, 2021

Conversation

pacoxu
Copy link
Member

@pacoxu pacoxu commented Jan 25, 2021 •
edited

What type of PR is this?
/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:
cherry-pick of #97764 for kubernetes-sigs/sig-windows-tools#138

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

kubelet should ignore cgroup driver check on Windows node.

@pacoxu
ignore cgroup driver check in windows node upgrade
d331e5f 
Signed-off-by: pacoxu <paco.xu@daocloud.io>
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jan 25, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Jan 25, 2021
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/kubelet labels Jan 25, 2021
@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 25, 2021
@neolit123
Copy link
Member

/lgtm
/priority important-soon
/triage accepted
/assign @mrunalp

@kubernetes/release-managers

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 26, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 26, 2021
@mrunalp
Copy link
Contributor

mrunalp commented Jan 26, 2021

/approve

@ehashman ehashman added this to Needs Approver in SIG Node PR Triage Jan 26, 2021
@hasheddan
Copy link
Contributor

/assign @sjenning

@sjenning
Copy link
Contributor

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 26, 2021
hasheddan
hasheddan approved these changes Jan 26, 2021
View reviewed changes
Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@hasheddan hasheddan added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jan 26, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Jan 26, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hasheddan, mrunalp, pacoxu, sjenning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 8672cfc into kubernetes:release-1.19 Jan 27, 2021
SIG Node PR Triage automation moved this from Needs Approver to Done Jan 27, 2021
@pacoxu pacoxu deleted the automated-cherry-pick-of-#97764-upstream-release-1.19 branch June 23, 2021 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasheddan hasheddan hasheddan approved these changes

@mtaufen mtaufen Awaiting requested review from mtaufen

@odinuge odinuge Awaiting requested review from odinuge

Assignees

@mrunalp mrunalp

@neolit123 neolit123

@sjenning sjenning

@hasheddan hasheddan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node PR Triage
Done
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@pacoxu @neolit123 @mrunalp @hasheddan @sjenning @k8s-ci-robot