Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

promote apiserver_request_duration_seconds to STABLE #99925

Merged
merged 1 commit into from Mar 8, 2021
Merged

promote apiserver_request_duration_seconds to STABLE #99925

merged 1 commit into from Mar 8, 2021

Conversation

logicalhan
Copy link
Member

@logicalhan logicalhan commented Mar 8, 2021 •
edited

This change promotes apiserver_request_duration_seconds to stable metric status.

Change-Id: I1b050b812738719aedd7ac6f4794ec742812e12d

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This is a common metric used for SLOs/SLIs. We are promoting this to stable status to preserve that intent while shedding less useful dimensions.

Which issue(s) this PR fixes:

Fixes #91536

Special notes for your reviewer:

We went over this in the SIG Api-Machinery meeting and agreed this was appropriate.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

apiserver_request_duration_seconds is promoted to stable status.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/tree/master/keps/sig-instrumentation/1209-metrics-stability

@logicalhan
promote apiserver_request_duration_seconds to STABLE
69e3d89 
Change-Id: I1b050b812738719aedd7ac6f4794ec742812e12d
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 8, 2021
@logicalhan
Copy link
Member Author

/sig api-machinery instrumentation
/priority important-soon

@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. area/apiserver area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 8, 2021
@deads2k
Copy link
Contributor

deads2k commented Mar 8, 2021

/lgtm
/approve

If the buckets need to change in the future, I gather we're allowed to do that.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 8, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, logicalhan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@logicalhan logicalhan mentioned this pull request Mar 8, 2021
Closed
@k8s-ci-robot k8s-ci-robot merged commit 72d9215 into kubernetes:master Mar 8, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Mar 8, 2021
@fedebongio
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coffeepac coffeepac Awaiting requested review from coffeepac

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

Assignees

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

Moving apiserver_request metrics to stable status
4 participants
@logicalhan @deads2k @k8s-ci-robot @fedebongio