Migrate pkg/proxy/util to structured logging
#104908
Conversation
k8s-ci-robot
added
release-note
|
Welcome @CIPHERTron! |
|
Hi @CIPHERTron. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
needs-ok-to-test
|
This PR is not correctly tagged for migration, please read instructions in https://github.com/kubernetes/community/blob/master/contributors/devel/sig-instrumentation/migration-to-structured-logging.md#what-to-include-in-the-pull-request |
CIPHERTron
changed the title
pkg/proxy/utilpkg/proxy/util to structured logging
|
/wg structured-logging |
k8s-ci-robot
added
wg/structured-logging
Sorry for the inconvenience @serathius. Is it okay now? |
|
/ok-to-test /lgtm |
k8s-ci-robot
added
ok-to-test
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bowei, CIPHERTron The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
removed
the
lgtm
|
In my latest commit, I've changed the key names in |
|
@CIPHERTron can you please fix the issue in your latest commit? Thanks! |
I'm not quite sure what's causing the tests to fail. Could you please help me out? |
see 39a6952 |
Isn't it supposed to be a commit from a branch on my fork? |
|
@CIPHERTron Nothing is wrong with your commits. Your commits do belong to the branch of your fork. Turns out Kubernetes bot is not brainy enough to use the right link for the commits in this PR in it's comment OR there is some issue with GitHub linking issues, which seems to be the case with some experimentation. The right link for the commit is - this or this. If you simply try to paste the kubernetes/kubernetes repo based commit link as is, that is this link So, that's the whole confusion I think. It's no way related to the test failure. The test failure is here k8s.io/kubernetes/vendor/k8s.io/legacy-cloud-providers/azure: TestCreateBlobDisk expand_less | 0s
-- | --
=== RUN TestCreateBlobDisk panic: test timed out after 3m0s goroutine 232 [running]: testing.(*M).startAlarm.func1() /usr/local/go/src/testing/testing.go:1788 +0xbb created by time.goFunc /usr/local/go/src/time/sleep.go:180 +0x4a goroutine 1 [chan receive]: testing.(*T).Run(0xc0002921a0, {0x251cb43, 0x12}, 0x25e6c40)
as mentioned in bot's comment with the link test as |
serathius
moved this from Waiting on Reviewer
to Waiting on Author
in WG Structured Logging - 1.23 Migration
|
@CIPHERTron can you please take a look at the review comments, |
Yeah, sorry about that. Was caught up with something else today! |
|
Heyy @thockin, I've addressed all your suggestions. Could you please do a final check and say if everything's good to go or it needs some more changes? Thanks a lot! |
|
/test pull-kubernetes-integration |
1 similar comment
|
/test pull-kubernetes-integration |
|
Heyy folks, do I have to squash merge it from my side? Thanks! |
|
@CIPHERTron: GitHub didn't allow me to request PR reviews from the following users: shivanshu1333. Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/unhold |
k8s-ci-robot
removed
the
do-not-merge/hold
* Migrate to Structured Logs in `pkg/proxy/util` * Minor fixes * change key to cidr and remove namespace arg * Update key from cidr to CIDR Co-authored-by: JUN YANG <69306452+yangjunmyfm192085@users.noreply.github.com> * Update key cidr to CIDR Co-authored-by: JUN YANG <69306452+yangjunmyfm192085@users.noreply.github.com> * Update key ip to IP Co-authored-by: JUN YANG <69306452+yangjunmyfm192085@users.noreply.github.com> * Update key ip to IP Co-authored-by: JUN YANG <69306452+yangjunmyfm192085@users.noreply.github.com> * Interchange svcNamespace and svcName * Change first letter of all messages to capital * Change key names in endpoints.go * Change all keynames to lower bumby caps convention Co-authored-by: JUN YANG <69306452+yangjunmyfm192085@users.noreply.github.com>
What type of PR is this?
/wg structured-logging
/area logging
/priority important-longterm
/kind cleanup
/cc @kubernetes/wg-structured-logging-reviews
What this PR does / why we need it:
Migrate kube-proxy to structured logs
Which issue(s) this PR fixes:
Reference #104872
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: