New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implements CrossNamespacePodAffinity quota scope #98582
Conversation
/assign @liggitt @alculquicondor |
This PR may require API review. If so, when the changes are ready, complete the pre-review checklist and request an API review. Status of requested reviews is tracked in the API Review project. |
/remove-sig api-machinery |
/sig auth |
lgtm, but leaving the official one to sig-auth |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
API and validation changes all look good, can squash in review commit. made one suggestion on the API doc.
5674216
to
302b633
Compare
pull-kubernetes-dependencies is a known failure unrelated to your PR that is being worked on |
change looks good, though generated API docs will probably need updating as well |
yup, done. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahg-g, liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/hold need to resolve some conflicts |
…ceSelector APIs, and CrossNamespacePodAffinity quota scope implementation.
/hold cancel |
/lgtm |
/retest |
1 similar comment
/retest |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Implements CrossNamespacePodAffinity quota scope
Which issue(s) this PR fixes:
Part of #97203
Special notes for your reviewer:
#98378 should merge first.
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
Please use the following format for linking documentation: