Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pause image: Adds 20H2 Windows OS Version base image #97322

Merged
merged 1 commit into from Dec 18, 2020
Merged

pause image: Adds 20H2 Windows OS Version base image #97322

merged 1 commit into from Dec 18, 2020

Conversation

claudiubelu
Copy link
Contributor

What type of PR is this?

/sig windows

/kind feature

What this PR does / why we need it:

A new Windows image has been released in the second half of 2020 with the tag 20H2.
We are going to need a pause image for it as well.

The image tag can be found here: https://hub.docker.com/_/microsoft-windows-nanoserver

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

The Kubernetes pause image manifest list now contains an image for Windows Server 20H2.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@claudiubelu
pause image: Adds 20H2 Windows OS Version base image
ad97a5b 
A new Windows image has been released in the second half of 2020 with the tag 20H2.
We are going to need a pause image for it as well.

The image tag can be found here: https://hub.docker.com/_/microsoft-windows-nanoserver
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/windows Categorizes an issue or PR as relevant to SIG Windows. kind/feature Categorizes issue or PR as related to a new feature. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 15, 2020
@k8s-ci-robot
Copy link
Contributor

@claudiubelu: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Dec 15, 2020
@immuzz immuzz added this to In Progress (v1.21) in SIG-Windows Dec 17, 2020
@randomvariable
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 18, 2020
@randomvariable
Copy link
Member

/assign @dims

simple enough change.

@jayunit100
Copy link
Member

/approve

@jayunit100
Copy link
Member

/lgtm

@dims
Copy link
Member

dims commented Dec 18, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: claudiubelu, dims, jayunit100

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 18, 2020
@k8s-ci-robot k8s-ci-robot merged commit 6fff958 into kubernetes:master Dec 18, 2020
SIG-Windows automation moved this from In Progress (v1.21) to Done (v1.21) Dec 18, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Dec 18, 2020
@github-actions github-actions bot mentioned this pull request Jan 5, 2021
Open
@pacoxu pacoxu mentioned this pull request Jan 20, 2021
Merged
10 tasks
@jsturtevant jsturtevant mentioned this pull request Mar 31, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder Awaiting requested review from BenTheElder

@dims dims Awaiting requested review from dims

Assignees

@dims dims

@jayunit100 jayunit100

@randomvariable randomvariable

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@claudiubelu @k8s-ci-robot @randomvariable @jayunit100 @dims