Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote SizeMemoryBackedVolumes to beta #100319

Merged
merged 1 commit into from Mar 17, 2021
Merged

Promote SizeMemoryBackedVolumes to beta #100319

merged 1 commit into from Mar 17, 2021

Conversation

derekwaynecarr
Copy link
Member

What type of PR is this?

/kind feature

What this PR does / why we need it:

Promotes existing Alpha feature to Beta.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

EmptyDir memory backed volumes are sized as the the minimum of pod allocatable memory on a host and an optional explicit user provided value.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP] https://github.com/kubernetes/enhancements/pull/2345

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 16, 2021
@derekwaynecarr
Copy link
Member Author

E2E testing was already defined and had coverage here:
https://github.com/kubernetes/kubernetes/blob/master/test/e2e/common/storage/empty_dir.go#L298

@ehashman
Copy link
Member

/sig node
/priority important-soon
/triage accepted

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 16, 2021
@ehashman ehashman added this to Needs Reviewer in SIG Node PR Triage Mar 16, 2021
@dims
Copy link
Member

dims commented Mar 16, 2021

/retitle Promote SizeMemoryBackedVolumes to beta

@k8s-ci-robot k8s-ci-robot changed the title Promote SizeMemoryBackedVolumeSizing to beta Promote SizeMemoryBackedVolumes to beta Mar 16, 2021
@dims
Copy link
Member

dims commented Mar 16, 2021

/retest

@dims
Copy link
Member

dims commented Mar 17, 2021

/approve
/lgtm
/milestone v1.21

@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Mar 17, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 17, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekwaynecarr, dims, zouyee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@derekwaynecarr
Copy link
Member Author

/test pull-kubernetes-e2e-kind
/test pull-kubernetes-e2e-gce-ubuntu-containerd

@k8s-ci-robot k8s-ci-robot merged commit 2f8a225 into kubernetes:master Mar 17, 2021
SIG Node PR Triage automation moved this from Needs Reviewer to Done Mar 17, 2021
@derekwaynecarr
Copy link
Member Author

@dims I had an exception open and did not intend for this to merge prior to hearing a response https://groups.google.com/g/kubernetes-sig-node/c/7w1vqksOqHY

@pacoxu pacoxu mentioned this pull request Apr 21, 2021
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zouyee zouyee zouyee approved these changes

@brendandburns brendandburns Awaiting requested review from brendandburns

@thockin thockin Awaiting requested review from thockin

Assignees

@dims dims

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node PR Triage
Done
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@derekwaynecarr @ehashman @dims @k8s-ci-robot @zouyee