New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix detach disk issue on deleting vmss node #104572
fix detach disk issue on deleting vmss node #104572
Conversation
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
@andrewsykim could you help to approve the bug fix? /assign @andrewsykim |
@andrewsykim @cheftako could you approve? thanks. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx, cheftako, feiskyer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I assume a cherry-pick to release-1.19 is not required, right? |
…104572-upstream-release-1.20 Automated cherry pick of #104572: fix detach disk issue on deleting node
…104572-upstream-release-1.21 Automated cherry pick of #104572: fix detach disk issue on deleting node
@saschagrunert correct, thanks. |
…104572-upstream-release-1.22 Automated cherry pick of #104572: fix detach disk issue on deleting node
What type of PR is this?
/kind bug
What this PR does / why we need it:
fix detach disk issue on deleting node
This PR is a proceeding fix with #95177
There was error msg format change when vmss node is in deleting state, this PR tries to fix this issue to make sure detach disk return success on vmss node which is being deleting
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
current error msg is like following:
/kind bug
/assign @feiskyer
/priority important-soon
/sig cloud-provider
/area provider/azure
/triage accepted
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: