Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[go1.16] Update to go1.16 #98572

Merged
merged 7 commits into from Mar 2, 2021
Merged

[go1.16] Update to go1.16 #98572

merged 7 commits into from Mar 2, 2021

Conversation

justaugustus
Copy link
Member

@justaugustus justaugustus commented Jan 29, 2021 •
edited

What type of PR is this?

/kind feature
/area dependency

What this PR does / why we need it:

  • Update to go1.16

Tracking issue: kubernetes/release#1834
Slack thread: https://kubernetes.slack.com/archives/C2C40FMNF/p1610074100305000
cc: @kubernetes/release-engineering

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

- Kubernetes is now built with Golang 1.16

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/provider/gcp Issues or PRs related to gcp provider area/release-eng Issues or PRs related to the Release Engineering subproject area/test sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 29, 2021
hasheddan
hasheddan approved these changes Jan 29, 2021
View reviewed changes
Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 29, 2021
@justaugustus
Copy link
Member Author

/assign @dims
FYI @nikhita

@justaugustus
Copy link
Member Author

(now why did I think this was going to be simple...)
/retest

@dims
Copy link
Member

dims commented Jan 29, 2021

@justaugustus is the intention to merge the RC1 or wait for the final release ( which is probably in a few days 🤞🏾 )

@justaugustus
Copy link
Member Author

@justaugustus is the intention to merge the RC1 or wait for the final release ( which is probably in a few days 🤞🏾 )

I was hoping to get the RC1 in, but we'll see what the tests have to say about that.
Depending on how timing lines up, this may just end up being the go1.16.0 PR.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 29, 2021
saschagrunert
saschagrunert approved these changes Mar 2, 2021
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 2, 2021
cpanato
cpanato approved these changes Mar 2, 2021
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@justaugustus
Copy link
Member Author

/test pull-kubernetes-integration-go-canary

@justaugustus justaugustus mentioned this pull request Mar 2, 2021
Closed
@justaugustus
Copy link
Member Author

pull-kubernetes-integration-go-canary passed as well: https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/98572/pull-kubernetes-integration-go-canary/1366759123974098944

@liggitt
Copy link
Member

liggitt commented Mar 2, 2021

/approve

@liggitt
Copy link
Member

liggitt commented Mar 2, 2021

/triage accepted
/priority important-soon

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 2, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, hasheddan, justaugustus, liggitt, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 2, 2021
@justaugustus
Copy link
Member Author

Screenshot from 2021-03-02 10-56-22

/label wake-up-bots
/honk

@k8s-ci-robot
Copy link
Contributor

@justaugustus: The label(s) /label wake-up-bots cannot be applied. These labels are supported: api-review

In response to this:

Screenshot from 2021-03-02 10-56-22

/label wake-up-bots
/honk

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

@justaugustus:
goose image

In response to this:

Screenshot from 2021-03-02 10-56-22

/label wake-up-bots
/honk

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cynepco3hahue cynepco3hahue mentioned this pull request Mar 2, 2021
Merged
@liggitt liggitt mentioned this pull request Mar 2, 2021
Merged
@k8s-ci-robot k8s-ci-robot merged commit e4e9c31 into kubernetes:master Mar 2, 2021
@liggitt liggitt mentioned this pull request Mar 2, 2021
Merged
@monopole monopole mentioned this pull request Mar 3, 2021
Closed
@ffromani ffromani mentioned this pull request Mar 3, 2021
Closed
@cpanato cpanato mentioned this pull request Mar 3, 2021
Merged
@chenyw1990 chenyw1990 mentioned this pull request Mar 5, 2021
Merged
@palnabarun palnabarun mentioned this pull request Mar 5, 2021
Merged
3 tasks
@justaugustus justaugustus mentioned this pull request Aug 13, 2021
Merged
@pacoxu pacoxu mentioned this pull request Sep 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikhita nikhita nikhita left review comments

@saschagrunert saschagrunert saschagrunert approved these changes

@cpanato cpanato cpanato approved these changes

@hasheddan hasheddan hasheddan approved these changes

@dims dims Awaiting requested review from dims

@feiskyer feiskyer Awaiting requested review from feiskyer

Assignees

@dims dims

@saschagrunert saschagrunert

@liggitt liggitt

@cpanato cpanato

@hasheddan hasheddan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/cloudprovider area/code-generation area/dependency Issues or PRs related to dependency changes area/kubectl area/provider/gcp Issues or PRs related to gcp provider area/release-eng Issues or PRs related to the Release Engineering subproject area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node CI/Test Board
Triage
SIG Node CI/Test Board
Archived in project
SIG Node PR Triage
Triage
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

None yet