Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set idle and readheader timeouts #103958

Merged
merged 1 commit into from Aug 5, 2021
Merged

Set idle and readheader timeouts #103958

merged 1 commit into from Aug 5, 2021

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Jul 27, 2021

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Ensure the apiserver has an opinion about lifetime of keep-alive requests, and sets a timeout on reading incoming request headers (which happens before the WithRequestDeadline filter sets a context deadline)

Does this PR introduce a user-facing change?

kube-apiserver: sets an upper-bound on the lifetime of idle keep-alive connections and time to read the headers of incoming requests

/sig api-machinery
/cc @wojtek-t

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. area/apiserver needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/kubelet approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/node Categorizes an issue or PR as relevant to SIG Node. labels Jul 27, 2021
@liggitt
Copy link
Member Author

liggitt commented Jul 27, 2021

/milestone v1.23

@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Jul 27, 2021
@liggitt
Copy link
Member Author

liggitt commented Jul 27, 2021 •
edited

/cc @sttts

since you were just in the request deadline stuff in 1.21 in #96901

@k8s-ci-robot k8s-ci-robot requested a review from sttts July 27, 2021 19:37
@deads2k
Copy link
Contributor

deads2k commented Jul 27, 2021

These values seem reasonable to me. I think clients had to handle getting timeouts either way.

/assign @sttts

@fedebongio
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 27, 2021
@liggitt
Copy link
Member Author

liggitt commented Jul 27, 2021

/retest

@wojtek-t
Copy link
Member

Thanks Jordan!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 28, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liggitt liggitt added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Jul 28, 2021
@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Jul 28, 2021
@liggitt liggitt mentioned this pull request Jul 28, 2021
Merged
This was referenced Jul 28, 2021
Merged
Merged
Merged
@ehashman ehashman added this to Triage in SIG Node PR Triage Aug 2, 2021
@ehashman ehashman moved this from Triage to Done in SIG Node PR Triage Aug 2, 2021
@ehashman ehashman moved this from Done to Needs Approver in SIG Node PR Triage Aug 2, 2021
@dims
Copy link
Member

dims commented Aug 5, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Aug 5, 2021
@liggitt
Copy link
Member Author

liggitt commented Aug 5, 2021

/retest

@k8s-ci-robot k8s-ci-robot merged commit 28990f7 into kubernetes:master Aug 5, 2021
SIG Node PR Triage automation moved this from Needs Approver to Done Aug 5, 2021
@liggitt liggitt deleted the server-timeouts branch August 6, 2021 18:22
k8s-ci-robot added a commit that referenced this pull request Aug 16, 2021
@k8s-ci-robot
Merge pull request #103990 from liggitt/automated-cherry-pick-of-#103…
b9d77cc 
…958-upstream-release-1.20

Automated cherry pick of #103958: Set idle and readheader timeouts
k8s-ci-robot added a commit that referenced this pull request Aug 16, 2021
@k8s-ci-robot
Merge pull request #103991 from liggitt/automated-cherry-pick-of-#103…
9cf0694 
…958-upstream-release-1.19

Automated cherry pick of #103958: Set idle and readheader timeouts
k8s-ci-robot added a commit that referenced this pull request Aug 16, 2021
@k8s-ci-robot
Merge pull request #103989 from liggitt/automated-cherry-pick-of-#103…
cb2ee55 
…958-upstream-release-1.21

Automated cherry pick of #103958: Set idle and readheader timeouts
k8s-ci-robot added a commit that referenced this pull request Aug 16, 2021
@k8s-ci-robot
Merge pull request #103988 from liggitt/automated-cherry-pick-of-#103…
b01ed54 
…958-upstream-release-1.22

[1.22.x] Automated cherry pick of #103958: Set idle and readheader timeouts
@hjorth hjorth mentioned this pull request Dec 22, 2021
Closed
@zishen zishen mentioned this pull request Aug 16, 2023
Closed
@wallrj wallrj mentioned this pull request Dec 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

@sttts sttts Awaiting requested review from sttts

Assignees

@sttts sttts

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/node Categorizes an issue or PR as relevant to SIG Node. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node PR Triage
Done
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@liggitt @deads2k @fedebongio @wojtek-t @k8s-ci-robot @dims @sttts