Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete deprecated mixed procotol annotation #97096

Merged
merged 1 commit into from Dec 9, 2020
Merged

Delete deprecated mixed procotol annotation #97096

merged 1 commit into from Dec 9, 2020

Conversation

nilo19
Copy link
Member

@nilo19 nilo19 commented Dec 7, 2020 •
edited by liggitt

What type of PR is this?

/kind cleanup

What this PR does / why we need it:
There are unexpected behaviors when setting service.beta.kubernetes.io/azure-load-balancer-mixed-protocols: "true". If two ports of TCP and UDP are set, four load balancing rules instead of two would be created. Since in v1.20 and later, the mixed protocols are supported when setting the feature gate MixedProtocolLBService to true, this annotation is not needed anymore.

Which issue(s) this PR fixes:

Fixes kubernetes-sigs/cloud-provider-azure#295

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Delete deprecated `service.beta.kubernetes.io/azure-load-balancer-mixed-protocols` mixed procotol annotation in favor of the MixedProtocolLBService feature

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/area provider/azure
/sig cloud-provider
/triage accepted
/priority important-soon

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/provider/azure Issues or PRs related to azure provider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. triage/accepted Indicates an issue or PR is ready to be actively worked on. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Dec 7, 2020
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cloudprovider labels Dec 7, 2020
@nilo19 nilo19 changed the title Deprecate the mixed protocols annotation Delete deprecated mixed procotol annotation Dec 7, 2020
@nilo19
Copy link
Member Author

nilo19 commented Dec 7, 2020

error when creating test cluster: The VM allocation failed due to an internal error. would retry later manually.

@nilo19
Copy link
Member Author

nilo19 commented Dec 7, 2020

/retest

1 similar comment
@nilo19
Copy link
Member Author

nilo19 commented Dec 7, 2020

/retest

feiskyer
feiskyer approved these changes Dec 7, 2020
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 7, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer, nilo19

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nilo19
Copy link
Member Author

nilo19 commented Dec 7, 2020

/retest

@k8s-ci-robot k8s-ci-robot merged commit 42d19f9 into kubernetes:master Dec 9, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Dec 9, 2020
@nilo19 nilo19 deleted the cleanup/deprecate-mix-protocol-annotation branch December 9, 2020 06:02
@github-actions github-actions bot mentioned this pull request Dec 16, 2020
Open
@alibo alibo mentioned this pull request Aug 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer feiskyer approved these changes

@andyzhangx andyzhangx Awaiting requested review from andyzhangx

Assignees

@feiskyer feiskyer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cloudprovider area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

Mixed protocols doesn't work on Azure
3 participants
@nilo19 @k8s-ci-robot @feiskyer