New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete deprecated mixed procotol annotation #97096
Delete deprecated mixed procotol annotation #97096
Conversation
error when creating test cluster: |
/retest |
1 similar comment
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: feiskyer, nilo19 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
There are unexpected behaviors when setting
service.beta.kubernetes.io/azure-load-balancer-mixed-protocols: "true"
. If two ports of TCP and UDP are set, four load balancing rules instead of two would be created. Since in v1.20 and later, the mixed protocols are supported when setting the feature gateMixedProtocolLBService
totrue
, this annotation is not needed anymore.Which issue(s) this PR fixes:
Fixes kubernetes-sigs/cloud-provider-azure#295
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
/area provider/azure
/sig cloud-provider
/triage accepted
/priority important-soon