Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vendor: upgrading cAdvisor to 0.37.5 #99209

Merged
merged 2 commits into from Mar 12, 2021
Merged

vendor: upgrading cAdvisor to 0.37.5 #99209

merged 2 commits into from Mar 12, 2021

Conversation

iwankgb
Copy link
Contributor

@iwankgb iwankgb commented Feb 18, 2021 •
edited by liggitt

What type of PR is this?

/kind bug

What this PR does / why we need it:

This PR upgrades cAdvisor 0.37.5 that fixes two bugs:

Which issue(s) this PR fixes:

Fixes #98870

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Fixes a regression in 1.19+ that caused cAdvisor to incorrectly detect single-socket multi-NUMA topology.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Feb 18, 2021
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 18, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @iwankgb. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/dependency Issues or PRs related to dependency changes labels Feb 18, 2021
@iwankgb
Copy link
Contributor Author

iwankgb commented Feb 18, 2021

/sig node

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 18, 2021
@dims
Copy link
Member

dims commented Feb 18, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 18, 2021
@iwankgb
Copy link
Contributor Author

iwankgb commented Feb 18, 2021

/retest

@bobbypage
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 18, 2021
@ehashman ehashman added this to Triage in SIG Node PR Triage Feb 19, 2021
ehashman
ehashman reviewed Feb 19, 2021
View reviewed changes
Copy link
Member

@ehashman ehashman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/triage accepted
/priority important-soon
/lgtm

@k8s-ci-robot k8s-ci-robot added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Feb 19, 2021
hasheddan
hasheddan approved these changes Feb 20, 2021
View reviewed changes
Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/assign @smarterclayton

BenTheElder
BenTheElder approved these changes Feb 20, 2021
View reviewed changes
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@iwankgb iwankgb mentioned this pull request Feb 20, 2021
Merged
@dims
Copy link
Member

dims commented Feb 20, 2021

/approve
/lgtm

/assign @liggitt (easy dependency update for cadvisor in release-1.19 Jordan)

@liggitt
Copy link
Member

liggitt commented Feb 22, 2021

did these fixes already land in master and release-1.20?

@iwankgb
Copy link
Contributor Author

iwankgb commented Feb 22, 2021

@liggitt:

@liggitt
Copy link
Member

liggitt commented Feb 22, 2021

if the bug affects master, fixes are expected to merge there first, demonstrate stability, and then be backported to release branches

@iwankgb
Copy link
Contributor Author

iwankgb commented Feb 22, 2021

Thanks, @liggitt. See: #99315.

@ehashman
Copy link
Member

if the bug affects master, fixes are expected to merge there first, demonstrate stability, and then be backported to release branches

oops, I missed that this hadn't hit master first. Assumed this was just a backport. #99315 has master matching #99207

@iwankgb
Copy link
Contributor Author

iwankgb commented Feb 22, 2021

@ehashman this one will never hit master - 1.19 use older version of cAdvisor than master and 1.20 do (0.37 vs o.38).

@ehashman
Copy link
Member

@iwankgb I am aware but we were missing the PR to master to match 1.20 :)

@liggitt
Copy link
Member

liggitt commented Feb 23, 2021

@ehashman this one will never hit master - 1.19 use older version of cAdvisor than master and 1.20 do (0.37 vs o.38).

It makes sense that there are parallel cadivisor branches/releases for the particular releases Kubernetes is using. As long as the fix this PR represents is in master and 1.20 and has demonstrated stability, that's the important thing. Once that is done, reassign me to tag this.

/unassign

@bobbypage
Copy link
Member

bobbypage commented Feb 24, 2021 •
edited

The corresponding fix has been merged to master in #99315.

Reassigning back to @liggitt for approvals.

/assign @liggitt

@liggitt
Copy link
Member

liggitt commented Feb 24, 2021

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 24, 2021
@mrunalp mrunalp moved this from Needs Approver to Done in SIG Node PR Triage Mar 2, 2021
@iwankgb iwankgb mentioned this pull request Mar 11, 2021
Merged
hasheddan
hasheddan approved these changes Mar 12, 2021
View reviewed changes
Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, dims, hasheddan, iwankgb, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hasheddan hasheddan added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 12, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Mar 12, 2021
@iwankgb
Copy link
Contributor Author

iwankgb commented Mar 12, 2021

/retest

@k8s-ci-robot k8s-ci-robot merged commit 9e2169b into kubernetes:release-1.19 Mar 12, 2021
@liggitt liggitt added the kind/regression Categorizes issue or PR as related to a regression from a prior release. label Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehashman ehashman ehashman left review comments

@BenTheElder BenTheElder BenTheElder approved these changes

@hasheddan hasheddan hasheddan approved these changes

@lavalamp lavalamp Awaiting requested review from lavalamp

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@dims dims

@bobbypage bobbypage

@BenTheElder BenTheElder

@liggitt liggitt

@smarterclayton smarterclayton

@ehashman ehashman

@hasheddan hasheddan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/regression Categorizes issue or PR as related to a regression from a prior release. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node PR Triage
Done
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@iwankgb @k8s-ci-robot @dims @bobbypage @liggitt @ehashman @BenTheElder @hasheddan @smarterclayton