New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deprecate audit.k8s.io/v1[alpha|beta]1 versions #98858
Conversation
/test pull-kubernetes-bazel-test |
This PR may require API review. If so, when the changes are ready, complete the pre-review checklist and request an API review. Status of requested reviews is tracked in the API Review project. |
/test pull-kubernetes-verify |
/remove-sig api-machinery This MIGHT need API review? That is separate from api-machinery. |
return nil, fmt.Errorf("unknown group version field %v in policy", gvk) | ||
} | ||
|
||
if gv != auditv1.SchemeGroupVersion { | ||
klog.Warningf("all resources under the alpha/beta version were deprecated - use %q instead", auditv1.SchemeGroupVersion) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
%q is deprecated and will be removed in a future release, use %q instead
is better to show what's being used and how to replace it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@soltysh thanks for your review.
updated
/remove-sig api-machinery |
/test pull-kubernetes-bazel-test |
/assign @smarterclayton |
/remove-sig api-machinery |
/test pull-kubernetes-e2e-gce-ubuntu-containerd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/triage accepted
/priority backlog
/lgtm
/label api-review
return nil, fmt.Errorf("unknown group version field %v in policy", gvk) | ||
} | ||
|
||
if gv != auditv1.SchemeGroupVersion { | ||
klog.Warningf("%q is deprecated and will be removed in a future release, use %q instead", gv, auditv1.SchemeGroupVersion) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indicate the specific version (v1.24) rather than "a future release"
@@ -247,6 +247,9 @@ func validateGroupVersionString(groupVersion string) error { | |||
if !knownGroupVersion(gv) { | |||
return fmt.Errorf("invalid group version, allowed versions are %q", knownGroupVersions) | |||
} | |||
if gv != auditv1.SchemeGroupVersion { | |||
klog.Warningf("%q is deprecated and will be removed in a future release, use %q instead", gv, auditv1.SchemeGroupVersion) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indicate the specific version (v1.24) rather than "a future release"
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: carlory, liggitt, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Review the full test history for this PR. Silence the bot with an |
/hold |
/hold cancel |
What type of PR is this?
/kind cleanup
/kind feature
/kind api-change
/kind deprecation
What this PR does / why we need it:
Since k8s v1.12 the API audit.k8s.io has a stable version V1, ref: #65891.
However, the v1alpha1 and v1beta1 versions of the API are still not deprecated and available.
marking audit.k8s.io/v1[alpha|beta]1 versions as deprecated and warning if a version other than audit.k8s.io/v1 was passed to the kube-apiserver flags
--audit-log-version
and--audit-webhook-version
.Which issue(s) this PR fixes:
ref #98035
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: