Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[go1.17] Update to go1.17.5 and golang.org/x/net to v0.0.0-20211209124913-491a49abca63 #106835

Merged
merged 5 commits into from Dec 13, 2021
Merged

[go1.17] Update to go1.17.5 and golang.org/x/net to v0.0.0-20211209124913-491a49abca63 #106835

merged 5 commits into from Dec 13, 2021

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Dec 6, 2021 •
edited

What type of PR is this?

/kind feature
/area dependency release-eng release-eng/security security

What this PR does / why we need it:

  • Update Kubernetes to go1.17.4 on release-1.23 branch
  • Update Kubernetes to go1.17.5 on release-1.23 branch
  • golang.org/x/net to v0.0.0-20211209124913-491a49abca63

Tracking issue: kubernetes/release#2341

/assign @dims @liggitt @justaugustus
cc: @kubernetes/release-engineering

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

- Kubernetes is now built with Golang 1.17.5
- golang.org/x/net to v0.0.0-20211209124913-491a49abca63

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@cpanato
[go1.17] Update to go1.17.4
8aef834 
Signed-off-by: Carlos Panato <ctadeu@gmail.com>
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Dec 6, 2021
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Dec 6, 2021
@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 6, 2021
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/dependency Issues or PRs related to dependency changes area/release-eng Issues or PRs related to the Release Engineering subproject labels Dec 6, 2021
@k8s-ci-robot
Copy link
Contributor

@cpanato: The label(s) area/release-eng/security cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?

/kind feature
/area dependency release-eng release-eng/security security

What this PR does / why we need it:

Update Kubernetes to go1.17.4 on release-1.23 branch

Tracking issue: kubernetes/release#2341

/assign @dims @liggitt @justaugustus
cc: @kubernetes/release-engineering

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Kubernetes is now built with Golang 1.17.4

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added area/security cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Dec 6, 2021
@cpanato cpanato mentioned this pull request Dec 6, 2021
Closed
24 tasks
@k8s-ci-robot k8s-ci-robot added area/provider/gcp Issues or PRs related to gcp provider area/test labels Dec 6, 2021
@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 6, 2021
@justaugustus
Copy link
Member

/hold for v1.23.1

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 6, 2021
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/apiserver area/cloudprovider area/code-generation area/kubectl sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 13, 2021
@cpanato cpanato changed the title [go1.17] Update to go1.17.4 [go1.17] Update to go1.17.5 and golang.org/x/net to v0.0.0-20211209124913-491a49abca63 Dec 13, 2021
@cpanato
Copy link
Member Author

cpanato commented Dec 13, 2021

cherry picked the change from those PRs #106981 and #106959 here

@cpanato cpanato mentioned this pull request Dec 13, 2021
Closed
@cpanato
Copy link
Member Author

cpanato commented Dec 13, 2021

From #106981 (comment):

not sure if we want to close the other in favor of this one, but if we merge #106835 I will rebase this after

@cpanato -- I would suggest cherry picking the commits from #106959 and #106981 onto this branch and closing those PRs out.

done

@cpanato cpanato mentioned this pull request Dec 13, 2021
Closed
27 tasks
@justaugustus
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 13, 2021
@dims
Copy link
Member

dims commented Dec 13, 2021

/approve
/lgtm

1 similar comment
@dims
Copy link
Member

dims commented Dec 13, 2021

/approve
/lgtm

@liggitt
Copy link
Member

liggitt commented Dec 13, 2021 •
edited

/approve
for dep update

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, dims, justaugustus, liggitt, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 13, 2021
@enj enj added this to Needs Triage in SIG Auth Old Dec 13, 2021
@justaugustus justaugustus added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Dec 13, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Dec 13, 2021
@k8s-ci-robot k8s-ci-robot merged commit 08ad4f2 into kubernetes:release-1.23 Dec 13, 2021
SIG Auth Old automation moved this from Needs Triage to Closed / Done Dec 13, 2021
@cpanato cpanato deleted the go117-release-1-23 branch December 14, 2021 08:30
@cpanato cpanato mentioned this pull request Dec 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justaugustus justaugustus justaugustus approved these changes

@saschagrunert saschagrunert saschagrunert approved these changes

@dashpole dashpole Awaiting requested review from dashpole

@jpbetz jpbetz Awaiting requested review from jpbetz

Assignees

@dims dims

@justaugustus justaugustus

@lavalamp lavalamp

@liggitt liggitt

@smarterclayton smarterclayton

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/cloudprovider area/code-generation area/dependency Issues or PRs related to dependency changes area/kubectl area/provider/gcp Issues or PRs related to gcp provider area/release-eng Issues or PRs related to the Release Engineering subproject area/security area/test cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Auth
Archived in project
SIG Auth Old
Closed / Done
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@cpanato @k8s-ci-robot @justaugustus @dims @saschagrunert @liggitt @lavalamp @smarterclayton