Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nil VMSS name when setting service to auto mode #97366

Merged
merged 1 commit into from Dec 19, 2020
Merged

Fix nil VMSS name when setting service to auto mode #97366

merged 1 commit into from Dec 19, 2020

Conversation

nilo19
Copy link
Member

@nilo19 nilo19 commented Dec 17, 2020 •
edited

What type of PR is this?

/kind bug

What this PR does / why we need it:
Mirror: kubernetes-sigs/cloud-provider-azure#439
When the mode selection annotation is set to auto mode, the VMSS name would be nil because of the wrong return parameter in scaleSet.GetVMSetNames. This PR fixes it.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Fix nil VMSS name when setting service to auto mode

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/sig cloud-provider
/area provider/azure
/priority important-soon
/triage accepted

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on. release-note Denotes a PR that will be considered when it comes time to generate release notes. area/cloudprovider and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 17, 2020
@nilo19
Copy link
Member Author

nilo19 commented Dec 17, 2020

/retest

@bl-ue
Copy link
Contributor

bl-ue commented Dec 18, 2020

/test pull-kubernetes-e2e-aks-engine-azure

1 similar comment
@bl-ue
Copy link
Contributor

bl-ue commented Dec 18, 2020

/test pull-kubernetes-e2e-aks-engine-azure

feiskyer
feiskyer reviewed Dec 18, 2020
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 18, 2020
@nilo19
Copy link
Member Author

nilo19 commented Dec 18, 2020

/assign @cheftako

@cheftako
Copy link
Member

/approve

FYI (I realize this is not a feature change)
Starting in v1.21, we are disallowing feature PRs into the built-in legacy cloud providers (i.e. k8s.io/legacy-cloud-providers). Any kind/feature PRs going forward will have to be approved by SIG Cloud Provider. See this mailing list thread for more details https://groups.google.com/g/kubernetes-sig-cloud-provider/c/UkG46pNc6Cw.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheftako, feiskyer, nilo19

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 18, 2020
@bl-ue
Copy link
Contributor

bl-ue commented Dec 18, 2020

/test pull-kubernetes-e2e-aks-engine-azure

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit b749a3a into kubernetes:master Dec 19, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Dec 19, 2020
@bl-ue
Copy link
Contributor

bl-ue commented Dec 19, 2020

@nilo19 I got your PR merged!!! 😄

@nilo19
Copy link
Member Author

nilo19 commented Dec 19, 2020

@nilo19 I got your PR merged!!! 😄

thanks

@bl-ue
Copy link
Contributor

bl-ue commented Dec 19, 2020

@nilo19 No problem. Hopefully you don't mind...

@nilo19 nilo19 deleted the bug/fix-vmss-name branch December 20, 2020 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer feiskyer left review comments

@brendandburns brendandburns Awaiting requested review from brendandburns

@justaugustus justaugustus Awaiting requested review from justaugustus

Assignees

@feiskyer feiskyer

@cheftako cheftako

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cloudprovider area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@nilo19 @bl-ue @cheftako @k8s-ci-robot @fejta-bot @feiskyer