Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update max data disk count with new instance types #94340

Merged
merged 1 commit into from Sep 2, 2020
Merged

Update max data disk count with new instance types #94340

merged 1 commit into from Sep 2, 2020

Conversation

ialidzhikov
Copy link
Contributor

@ialidzhikov ialidzhikov commented Aug 30, 2020 •
edited

What type of PR is this?
/kind bug

What this PR does / why we need it:
Update max data disk count with new instance types.
I used #77461 (comment) to generate the list.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

New Azure instance types do now have correct max data disk count information.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@ialidzhikov
Update max data disk count with new instance types
2327e32 
Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 30, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @ialidzhikov. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 30, 2020
@ialidzhikov
Copy link
Contributor Author

/sig cloud-provider
/area provider/azure

@k8s-ci-robot k8s-ci-robot added sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. area/provider/azure Issues or PRs related to azure provider labels Aug 30, 2020
feiskyer
feiskyer reviewed Aug 31, 2020
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/priority important-soon

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 31, 2020
@feiskyer feiskyer added this to In progress in Provider Azure via automation Aug 31, 2020
@feiskyer
Copy link
Member

/retest

feiskyer
feiskyer reviewed Sep 2, 2020
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/milestone v1.20

@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Sep 2, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 2, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer, ialidzhikov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 2, 2020
@k8s-ci-robot k8s-ci-robot merged commit 5f79e91 into kubernetes:master Sep 2, 2020
Provider Azure automation moved this from In progress to Done Sep 2, 2020
This was referenced Nov 10, 2020
Merged
Merged
Merged
k8s-ci-robot added a commit that referenced this pull request Nov 17, 2020
@k8s-ci-robot
Merge pull request #96407 from andyzhangx/automated-cherry-pick-of-#9…
500f987 
…4340-upstream-release-1.18

Automated cherry pick of #94340: Update max data disk count with new instance types
k8s-ci-robot added a commit that referenced this pull request Nov 17, 2020
@k8s-ci-robot
Merge pull request #96412 from andyzhangx/automated-cherry-pick-of-#9…
50e8f77 
…4340-upstream-release-1.17

Automated cherry pick of #94340: Update max data disk count with new instance types
k8s-ci-robot added a commit that referenced this pull request Nov 17, 2020
@k8s-ci-robot
Merge pull request #96406 from andyzhangx/automated-cherry-pick-of-#9…
1758051 
…4340-upstream-release-1.19

Automated cherry pick of #94340: Update max data disk count with new instance types
@ialidzhikov ialidzhikov deleted the fix/max-data-disk-count branch January 9, 2021 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer feiskyer left review comments

@brendandburns brendandburns Awaiting requested review from brendandburns

@khenidak khenidak Awaiting requested review from khenidak

Assignees

@feiskyer feiskyer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
Provider Azure
  
Done
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ialidzhikov @k8s-ci-robot @feiskyer