New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Promote PodDisruptionBudget to policy/v1 #99290
Conversation
This PR may require API review. If so, when the changes are ready, complete the pre-review checklist and request an API review. Status of requested reviews is tracked in the API Review project. |
4eaccf4
to
4fc55d6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left you some initial comments, you're also missing necessary changes to pkg/api/testing/defaulting_test.go
which you can see from unit-test failure from that package.
2949f71
to
bf8cad0
Compare
/cc @wojtek-t |
bf8cad0
to
8a917de
Compare
/test pull-kubernetes-integration |
@mortent: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
2 similar comments
@mortent: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@mortent: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
rebased with no conflicts |
/retest |
@mortent: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/test pull-kubernetes-integration |
integration flake is #98116 (comment) |
hey folks, 1.21 Release Notes team here -- want to check in and disambiguate this line:
does this behavior warrant this note to be in |
No, there are no side effects to existing v1beta1 consumers that require action prior to upgrade to 1.21. |
What type of PR is this?
/kind api-change
/kind feature
What this PR does / why we need it:
This promotes
PodDisruptionBudget
resource topolicy/v1
based on kubernetes/enhancements#85 and detailed description in https://github.com/kubernetes/enhancements/tree/master/keps/sig-apps/85-Graduate-PDB-to-StableWhich issue(s) this PR fixes:
Fixes #95083
Special notes for your reviewer:
This replaces an older PR at #81571.
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: