Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #107786: Revert "Fix comparison between FQDN and hostname" #107902

Merged
merged 2 commits into from Feb 2, 2022
Merged

Automated cherry pick of #107786: Revert "Fix comparison between FQDN and hostname" #107902

merged 2 commits into from Feb 2, 2022

Conversation

xueqzhan
Copy link
Contributor

@xueqzhan xueqzhan commented Feb 1, 2022 •
edited by deads2k

Cherry pick of #107786 on release-1.23.

#107786: Revert "Fix comparison between FQDN and hostname"

For details on the cherry pick process, see the cherry pick requests page.

fix e2e test "Services should respect internalTrafficPolicy=Local Pod and Node, to Pod (hostNetwork: true)"

@mandre @xueqzhan
Revert "Fix comparison between FQDN and hostname"
733c0eb 
This reverts commit 752a532.
@mandre @xueqzhan
Ensure the execHostnameTest() compares hostnames
0d48717 
We do not have guarantee that the agnhost's `/hostname` endpoint returns
a hostname and not an FQDN. We also do not have guarantee a hostname
gets passed to the execHostnameTest() function for comparison.

So make sure we're comparing hostnames in execHostnameTest().
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Feb 1, 2022
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 1, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @xueqzhan!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

@xueqzhan: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

Hi @xueqzhan. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 1, 2022
@k8s-ci-robot k8s-ci-robot added area/test sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 1, 2022
@deads2k
Copy link
Contributor

deads2k commented Feb 1, 2022

/kind bug
/sig network

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Feb 1, 2022
@deads2k deads2k added the area/provider/openstack Issues or PRs related to openstack provider label Feb 1, 2022
@deads2k
Copy link
Contributor

deads2k commented Feb 1, 2022

/ok-to-test
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 1, 2022
@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 1, 2022
@deads2k
Copy link
Contributor

deads2k commented Feb 1, 2022

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 1, 2022
saschagrunert
saschagrunert approved these changes Feb 2, 2022
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@saschagrunert saschagrunert added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 2, 2022
@k8s-ci-robot k8s-ci-robot merged commit 7c7f40d into kubernetes:release-1.23 Feb 2, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, saschagrunert, xueqzhan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

xueqzhan pushed a commit to xueqzhan/kubernetes that referenced this pull request Feb 2, 2022
@k8s-ci-robot @xueqzhan
Merge pull request kubernetes#107902 from xueqzhan/automated-cherry-p…
59db1a6 
…ick-of-#107786-upstream-release-1.23

Automated cherry pick of kubernetes#107786: Revert "Fix comparison between FQDN and hostname"
@openshift-ci openshift-ci bot mentioned this pull request Feb 2, 2022
Closed
xueqzhan pushed a commit to xueqzhan/kubernetes that referenced this pull request Feb 2, 2022
@k8s-ci-robot @xueqzhan
UPSTREAM: 107902: Merge pull request kubernetes#107902 from xueqzhan/…
7e84598 
…automated-cherry-pick-of-#107786-upstream-release-1.23

Automated cherry pick of kubernetes#107786: Revert "Fix comparison between FQDN and hostname"
xueqzhan pushed a commit to xueqzhan/kubernetes that referenced this pull request Feb 2, 2022
@k8s-ci-robot @xueqzhan
UPSTREAM: 107902: Merge pull request kubernetes#107902 from xueqzhan/…
0a5757a 
…automated-cherry-pick-of-#107786-upstream-release-1.23

Automated cherry pick of kubernetes#107786: Revert "Fix comparison between FQDN and hostname"
@openshift-ci openshift-ci bot mentioned this pull request Feb 2, 2022
Merged
openshift-merge-robot added a commit to openshift/kubernetes that referenced this pull request Feb 4, 2022
@openshift-merge-robot
Merge pull request #1167 from xueqzhan/hostname_bug
d99c04f 
Bug 2050247: UPSTREAM: 107902: Merge pull request kubernetes#107902 from xueqzhan/automated-…
This was referenced Feb 15, 2022
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@johnbelamaric johnbelamaric Awaiting requested review from johnbelamaric

@khenidak khenidak Awaiting requested review from khenidak

Assignees

@saschagrunert saschagrunert

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/openstack Issues or PRs related to openstack provider area/test cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@xueqzhan @k8s-ci-robot @deads2k @saschagrunert @mandre