Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubectl diff: update regex to allow equal sign #98158

Merged
merged 1 commit into from Jan 20, 2021
Merged

kubectl diff: update regex to allow equal sign #98158

merged 1 commit into from Jan 20, 2021

Conversation

dougsland
Copy link
Member

When using GNU diffutils, some commands (e.g. --color[=WHEN])
requires an equal sign.

Signed-off-by: Douglas Schilling Landgraf dougsland@redhat.com
What type of PR is this?

/kind bug

What this PR does / why we need it:
Allow users to use external diff commands using = sign, example:

$ export KUBECTL_EXTERNAL_DIFF="diff --color=auto"; kubectl diff -f deploy.yaml

Which issue(s) this PR fixes:
Fixes #kubernetes/kubectl#1007

Does this PR introduce a user-facing change?:

KUBECTL_EXTERNAL_DIFF now accepts equal sign for additional parameters.

/sig cli

@dougsland
kubectl diff: update regex to allow equal param
722751a 
When using GNU diffutils, some commands (e.g. --color[=WHEN])
requires an equal sign.

Signed-off-by: Douglas Schilling Landgraf <dougsland@redhat.com>
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. sig/cli Categorizes an issue or PR as relevant to SIG CLI. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 19, 2021
@dougsland
Copy link
Member Author

/assign @seans3
/assign @eddiezane

@dougsland
Copy link
Member Author

/priority backlog
/triage accepted

@k8s-ci-robot k8s-ci-robot added priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 19, 2021
@dougsland
Copy link
Member Author

/test pull-kubernetes-bazel-test

@dougsland
Copy link
Member Author

/cc @rikatz

@rikatz
Copy link
Contributor

rikatz commented Jan 19, 2021

@dougsland nice catch! Thanks!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 19, 2021
@pwittrock
Copy link
Member

/approve

1 similar comment
@pwittrock
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dougsland, pwittrock

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 20, 2021
@k8s-ci-robot k8s-ci-robot merged commit ab21bdb into kubernetes:master Jan 20, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianpursley brianpursley Awaiting requested review from brianpursley

@dixudx dixudx Awaiting requested review from dixudx

@rikatz rikatz Awaiting requested review from rikatz

Assignees

@eddiezane eddiezane

@rikatz rikatz

@seans3 seans3

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@dougsland @rikatz @pwittrock @k8s-ci-robot @eddiezane @seans3