Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating EndpointSlice controllers to avoid duplicate creations #100103

Merged
merged 1 commit into from Mar 11, 2021
Merged

Updating EndpointSlice controllers to avoid duplicate creations #100103

merged 1 commit into from Mar 11, 2021

Conversation

robscott
Copy link
Member

What type of PR is this?

/kind bug

What this PR does / why we need it:

This updates the StaleSlices() method in EndpointSliceTracker to also ensure that the tracker does not have more slices than have been provided.

Which issue(s) this PR fixes:

Fixes #100033

Special notes for your reviewer:

This is a simpler replacement for #100042 after @lavalamp made it clear that we could depend on reliably getting deletes in onEndpointSliceDelete. I had previously thought that some deletes might get missed by these handlers.

Does this PR introduce a user-facing change?

EndpointSlice controllers are less likely to create duplicate EndpointSlices.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/cc @aojea @lavalamp @swetharepakula @wojtek-t
/assign @freehan
/sig network
/priority important-soon

@robscott @swetharepakula
Updating EndpointSlice controllers to avoid duplicate creations
730d7dc 
This updates the StaleSlices() method in EndpointSliceTracker to also
ensure that the tracker does not have more slices than have been
provided.

Co-Authored-By: Swetha Repakula <srepakula@google.com>
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. sig/network Categorizes an issue or PR as relevant to SIG Network. labels Mar 10, 2021
@k8s-ci-robot k8s-ci-robot requested a review from aojea March 10, 2021 21:18
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Mar 10, 2021
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 10, 2021
@k8s-ci-robot
Copy link
Contributor

@robscott: GitHub didn't allow me to request PR reviews from the following users: swetharepakula.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

What type of PR is this?

/kind bug

What this PR does / why we need it:

This updates the StaleSlices() method in EndpointSliceTracker to also ensure that the tracker does not have more slices than have been provided.

Which issue(s) this PR fixes:

Fixes #100033

Special notes for your reviewer:

This is a simpler replacement for #100042 after @lavalamp made it clear that we could depend on reliably getting deletes in onEndpointSliceDelete. I had previously thought that some deletes might get missed by these handlers.

Does this PR introduce a user-facing change?

EndpointSlice controllers are less likely to create duplicate EndpointSlices.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/cc @aojea @lavalamp @swetharepakula @wojtek-t
/assign @freehan
/sig network
/priority important-soon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Mar 10, 2021
@k8s-ci-robot
Copy link
Contributor

@robscott: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/apps Categorizes an issue or PR as relevant to SIG Apps. labels Mar 10, 2021
@robscott robscott mentioned this pull request Mar 10, 2021
Closed
@aojea
Copy link
Member

aojea commented Mar 10, 2021

@swetharepakula you should apply to the kubernetes org membership
https://github.com/kubernetes/community/blob/master/github-management/new-membership-procedure.md
lgtm

freehan
freehan reviewed Mar 11, 2021
View reviewed changes
Copy link
Contributor

@freehan freehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 11, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: freehan, robscott, swetharepakula

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@annajung
Copy link

/milestone v1.21

bug fix improves test coverage of existing code that was merged in before code freeze

@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Mar 11, 2021
robscott added a commit to robscott/kubernetes that referenced this pull request Mar 11, 2021
@robscott
Rolling back PR 100027
68cfaa4 
This PR was filed as a temporary workaround to reduce flakiness. Now
that the root cause has been fixed by kubernetes#100103 we can restore the full
test.
@robscott robscott mentioned this pull request Mar 11, 2021
Merged
@k8s-ci-robot k8s-ci-robot merged commit e2cdf0e into kubernetes:master Mar 11, 2021
wawa0210 referenced this pull request in wawa0210/kubernetes Mar 12, 2021
@robscott @wawa0210
Rolling back PR 100027
869fe36 
This PR was filed as a temporary workaround to reduce flakiness. Now
that the root cause has been fixed by #100103 we can restore the full
test.
@liggitt liggitt mentioned this pull request May 6, 2021
Merged
@liggitt
Copy link
Member

liggitt commented May 6, 2021

This fixed a flaky test added in 1.21 which was picked to 1.19 and 1.20. Should this fix also be picked to 1.19 and 1.20?

@aojea aojea mentioned this pull request May 6, 2021
Merged
k8s-ci-robot added a commit that referenced this pull request May 6, 2021
@k8s-ci-robot
Merge pull request #101763 from aojea/automated-cherry-pick-of-#10010…
fee056f 
…3-upstream-release-1.20

Automated cherry pick of #100103: Updating EndpointSlice controllers to avoid duplicate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freehan freehan freehan left review comments

@swetharepakula swetharepakula swetharepakula approved these changes

@aojea aojea Awaiting requested review from aojea

@lavalamp lavalamp Awaiting requested review from lavalamp

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

Assignees

@freehan freehan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/network Categorizes an issue or PR as relevant to SIG Network. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

EndpointSlice Controllers create duplicate EndpointSlices in certain cases
7 participants
@robscott @k8s-ci-robot @aojea @annajung @liggitt @freehan @swetharepakula