Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cherry pick of knp 0.0.27 #107037

Merged
merged 1 commit into from Jan 6, 2022
Merged

cherry pick of knp 0.0.27 #107037

merged 1 commit into from Jan 6, 2022

Conversation

jdnurme
Copy link
Contributor

@jdnurme jdnurme commented Dec 14, 2021 •
edited by liggitt

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Updates konnectivity-network-proxy to v0.0.27. This includes a memory leak fix for the network proxy

see: #106922

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Updates konnectivity-network-proxy to v0.0.27. This includes a memory leak fix for the network proxy

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot
Copy link
Contributor

@jdnurme: This cherry pick PR is for a release branch and has not yet been approved by Release Managers.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved (/lgtm + /approve) by the relevant OWNERS.

AFTER it has been approved by code owners, please ping the kubernetes/release-managers team in a comment to request a cherry pick review.

(For details on the patch release process and schedule, see the Patch Releases page.)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Dec 14, 2021
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 14, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @jdnurme. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/apiserver area/cloudprovider labels Dec 14, 2021
@k8s-ci-robot k8s-ci-robot added area/dependency Issues or PRs related to dependency changes area/provider/gcp Issues or PRs related to gcp provider sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 14, 2021
@liggitt
Copy link
Member

liggitt commented Dec 15, 2021 •
edited

please update the description and release note referencing the memory leak being fixed (and the master PR)

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Dec 15, 2021
@liggitt liggitt removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 15, 2021
@cheftako @jdnurme
cherry pick of knp 0.0.27
78e8cb0 
undo of utils update
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Dec 16, 2021
@fedebongio
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Dec 16, 2021
@caesarxuchao
Copy link
Member

/retest

rata
rata approved these changes Dec 20, 2021
View reviewed changes
Copy link
Member

@rata rata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks for the backport @jdnurme ! :)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jdnurme, liggitt, rata

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fedebongio
Copy link
Contributor

/remove-triage accepted

@k8s-ci-robot k8s-ci-robot removed the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Dec 21, 2021
@fedebongio
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 21, 2021
@rata
Copy link
Member

rata commented Dec 21, 2021

Who can/should approve the cherry-pick ?

@aojea
Copy link
Member

aojea commented Dec 21, 2021

ping @kubernetes/release-managers

@xmudrii
Copy link
Member

xmudrii commented Dec 21, 2021 •
edited

Is only 1.23 affected or should we cherry-pick to other branches as well?

@PratikDeoghare PratikDeoghare mentioned this pull request Dec 22, 2021
Merged
@rata
Copy link
Member

rata commented Dec 22, 2021

@xmudrii other branches are affected as well. This should also be backported to 1.21 and 1.22 too

@jkh52 did some changes to allow this to be backported as lower as 1.21 (see kubernetes-sigs/apiserver-network-proxy@084136e)

@xmudrii
Copy link
Member

xmudrii commented Dec 22, 2021

@rata Thanks for the update! Can you please also create other cherry-picks and get them approved? We tend to prefer to merge cherry-picks fixing the same issue across release branches at the same time.

This was referenced Dec 22, 2021
Merged
Merged
@rata
Copy link
Member

rata commented Dec 22, 2021

@xmudrii thanks, I've just created the others :)

@rata
Copy link
Member

rata commented Dec 22, 2021

@jdnurme please take a look if you can you too :)

@jkh52
Copy link
Contributor

jkh52 commented Dec 22, 2021 •
edited

EDIT: please updates the server and agent images to match which is proper per https://github.com/kubernetes-sigs/apiserver-network-proxy/blob/master/RELEASE.md

/lgtm

@rata
Copy link
Member

rata commented Dec 23, 2021

@jkh52 who are you talking to? I don't have permissions to do anything in that doc. So, I assume you are talking to @jdnurme ?

Also, what images are missing update? This PR does update the manifests, and the tags exist in the anp repo (https://github.com/kubernetes-sigs/apiserver-network-proxy/tags). What is missing?

@jkh52
Copy link
Contributor

jkh52 commented Dec 23, 2021

@jkh52 who are you talking to? I don't have permissions to do anything in that doc. So, I assume you are talking to @jdnurme ?

Also, what images are missing update? This PR does update the manifests, and the tags exist in the anp repo (https://github.com/kubernetes-sigs/apiserver-network-proxy/tags). What is missing?

Sorry for causing confusion, too many tabs open. I mean that feeback for #107069. This PR looks correct.

@enj enj added this to Needs Triage in SIG Auth Old Jan 3, 2022
@justaugustus justaugustus added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jan 6, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Jan 6, 2022
@k8s-ci-robot k8s-ci-robot merged commit d43fec7 into kubernetes:release-1.23 Jan 6, 2022
SIG Auth Old automation moved this from Needs Triage to Closed / Done Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rata rata rata approved these changes

@andrewsykim andrewsykim Awaiting requested review from andrewsykim

@cheftako cheftako Awaiting requested review from cheftako

Assignees

@liggitt liggitt

@jkh52 jkh52

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/cloudprovider area/dependency Issues or PRs related to dependency changes area/provider/gcp Issues or PRs related to gcp provider cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Auth
Archived in project
SIG Auth Old
Closed / Done
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

None yet