Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrading cAdvisor to 0.38.8 #99315

Merged
merged 1 commit into from Feb 23, 2021
Merged

Upgrading cAdvisor to 0.38.8 #99315

merged 1 commit into from Feb 23, 2021

Conversation

iwankgb
Copy link
Contributor

@iwankgb iwankgb commented Feb 22, 2021 •
edited by liggitt

What type of PR is this?

/kind bug

What this PR does / why we need it:

This PR upgrades cAdvisor 0.38.8 that fixes two bugs:

Which issue(s) this PR fixes:

Fixes #98870

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Fixes a regression in 1.19+ that caused cAdvisor to incorrectly detect single-socket multi-NUMA topology.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 22, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @iwankgb. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 22, 2021
@k8s-ci-robot k8s-ci-robot requested review from dchen1107, thockin and a team February 22, 2021 18:39
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 22, 2021
@iwankgb iwankgb mentioned this pull request Feb 22, 2021
Merged
ehashman
ehashman approved these changes Feb 22, 2021
View reviewed changes
Copy link
Member

@ehashman ehashman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/sig node
/triage accepted
/priority important-soon
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/node Categorizes an issue or PR as relevant to SIG Node. triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 22, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 22, 2021
@iwankgb
Copy link
Contributor Author

iwankgb commented Feb 22, 2021

/retest

2 similar comments
@iwankgb
Copy link
Contributor Author

iwankgb commented Feb 22, 2021

/retest

@iwankgb
Copy link
Contributor Author

iwankgb commented Feb 22, 2021

/retest

@bobbypage
Copy link
Member

/lgtm

@ehashman ehashman added this to Needs Approver in SIG Node PR Triage Feb 22, 2021
@bobbypage
Copy link
Member

/retest

@mrunalp
Copy link
Contributor

mrunalp commented Feb 23, 2021

/approve

@mrunalp mrunalp moved this from Needs Approver to Done in SIG Node PR Triage Feb 23, 2021
@bobbypage
Copy link
Member

/assign @dchen1107 for root approvals

@dchen1107
Copy link
Member

/lgtm
/approve

Do we need to cherrypick to 1.20?

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dchen1107, ehashman, iwankgb, mrunalp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 23, 2021
@iwankgb
Copy link
Contributor Author

iwankgb commented Feb 23, 2021

/test pull-kubernetes-bazel-test

@iwankgb
Copy link
Contributor Author

iwankgb commented Feb 23, 2021

@dchen1107 while not being aware of the process I created a separate PR for 1.20: #99207.
Should I close it and create a cherry pick one?

@iwankgb
Copy link
Contributor Author

iwankgb commented Feb 23, 2021

/test pull-kubernetes-e2e-gce-ubuntu-containerd

@k8s-ci-robot k8s-ci-robot merged commit 1c6335d into kubernetes:master Feb 23, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Feb 23, 2021
@bobbypage
Copy link
Member

bobbypage commented Feb 24, 2021 •
edited

@dchen1107

Do we need to cherrypick to 1.20?

Cherrypick has already been made in #99207. @iwankgb, that should be ready to go now since master has been updated.

@iwankgb iwankgb deleted the cadvisor_0.38.8_to_master branch February 24, 2021 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehashman ehashman ehashman approved these changes

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@thockin thockin Awaiting requested review from thockin

Assignees

@bobbypage bobbypage

@ehashman ehashman

@dchen1107 dchen1107

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node PR Triage
Done
Milestone
v1.21
6 participants
@iwankgb @k8s-ci-robot @bobbypage @mrunalp @dchen1107 @ehashman