Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate prober.probe logs to structured logging #97093

Merged
merged 1 commit into from Mar 9, 2021
Merged

Migrate prober.probe logs to structured logging #97093

merged 1 commit into from Mar 9, 2021

Conversation

aldudko
Copy link
Contributor

@aldudko aldudko commented Dec 6, 2020 •
edited by liggitt

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Ref:

Does this PR introduce a user-facing change?:

NONE

Verify log output
Log output "Probe is nil"

# before
W1206 23:02:02.337481   31606 prober.go:106] Startup probe for kube-controller-manager-base-vm_kube-system(4cd8806580e432b1c63883b56257bc25):kube-controller-manager is nil

# after
I1206 23:06:44.267132   32349 prober.go:105] "Probe is nil" probeType="Liveness" pod="kube-system/kube-controller-manager-base-vm" podUID=4cd8806580e432b1c63883b56257bc25 container="kube-controller-manager"

Log output for "Probe succeeded"

# before
I1206 20:17:47.037248    1639 prober.go:126] Readiness probe for "goldpinger-x4brf_kube-system(c1520e6b-d0d3-4de9-9c77-3ccd5274f2e9):goldpinger" succeeded

# after
I1205 05:59:13.870209   26485 prober.go:126] "Probe succeeded" probeType="Readiness" pod="kube-system/goldpinger-vsx6p" podUID=bd4f52ad-2dd1-48f7-9e3e-c36b2110e18a container="goldpinger"

Log output for "Probe failed"

# before
I1206 20:29:49.515531   14870 prober.go:117] Liveness probe for "goldpinger-6nhdw_kube-system(18ce9b70-c8da-4e27-bb5c-e8490fc32e06):goldpinger" failed (failure): Get "http://100.96.0.31:8081/healthz": dial tcp 100.96.0.31:8081: connect: connection refused

# after
I1206 04:13:50.341041   11875 prober.go:117] "Probe failed" probeType="Liveness" pod="kube-system/goldpinger-8trpg" podUID=f119e663-3996-4b8e-8a43-2eed332a1b59 container="goldpinger" probeResult=failure output="Get \"http://100.96.0.15:8081/healthz\": dial tcp 100.96.0.15:8081: connect: connection refused"

Log output for "Probe errored"

# before
I1206 22:02:04.426351   12917 prober.go:114] Liveness probe for "testpod_default(9e67df23-47d3-4155-b5b8-fbb2b3406562):test" errored: rpc error: code = DeadlineExceeded desc = failed to exec in container: timeout 2s exceeded: context deadline exceeded

# after
E1206 22:52:25.670555   29450 prober.go:114] "Probe errored" err="some error" probeType="Liveness" pod="kube-system/coredns-f9fd979d6-bnk8l" podUID=3c6f90a9-9401-44ee-98a0-29e2a8e14969 container="coredns"

Log output for "Probe succeeded with a warning"

# before
I1206 22:56:14.129965   30273 prober.go:125] Readiness probe for "coredns-f9fd979d6-5wm5l_kube-system(50ad0836-ec52-4909-bcb1-afc938010b05):coredns" succeeded with a warning: OK

# after
I1206 22:58:33.453114   30767 prober.go:124] "Probe succeeded with a warning" probeType="Readiness" pod="kube-system/kube-apiserver-base-vm" podUID=7e0fc438e5bc254e28ac1bc58e27e32b container="kube-apiserver" output="ok"

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 6, 2020
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 6, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @aldudko!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @aldudko. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Dec 6, 2020
@k8s-ci-robot k8s-ci-robot added area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 7, 2020
@aldudko
Copy link
Contributor Author

aldudko commented Dec 7, 2020

signed CLA.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Dec 7, 2020
@aldudko
Copy link
Contributor Author

aldudko commented Dec 16, 2020

@yujuhong @dchen1107 could take a look at this PR please?

@ehashman
Copy link
Member

/sig instrumentation
/ok-to-test

@aldudko Thanks for your first contribution 🎉 Please add a release note about the migration to structured logging, as this is a user-facing change. See https://github.com/kubernetes/community/blob/master/contributors/guide/release-notes.md#does-my-pull-request-need-a-release-note

@k8s-ci-robot k8s-ci-robot added sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 21, 2020
@ehashman
Copy link
Member

/cc @serathius
/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Dec 21, 2020
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 21, 2020
@aldudko
Copy link
Contributor Author

aldudko commented Dec 21, 2020

Added a release note.

/retest

@serathius
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 5, 2021
@aldudko
Copy link
Contributor Author

aldudko commented Jan 5, 2021

/assign @dchen1107

@ehashman ehashman added this to Needs Approver in SIG Node PR Triage Jan 6, 2021
@dashpole
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 13, 2021
@derekwaynecarr
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aldudko, derekwaynecarr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2021
@derekwaynecarr derekwaynecarr moved this from Needs Approver to Done in SIG Node PR Triage Mar 4, 2021
@ehashman ehashman moved this from Needs Approver to Done in Structured Logging Migration for Kubelet, 1.21 Mar 4, 2021
@ehashman ehashman mentioned this pull request Mar 4, 2021
Closed
@pacoxu
Copy link
Member

pacoxu commented Mar 9, 2021

/test pull-kubernetes-unit
the bot hangs for merge this PR

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 11e9c32 into kubernetes:master Mar 9, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Mar 9, 2021
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Mar 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@yujuhong yujuhong Awaiting requested review from yujuhong

@serathius serathius Awaiting requested review from serathius

Assignees

@serathius serathius

@dchen1107 dchen1107

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/node Categorizes an issue or PR as relevant to SIG Node. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node PR Triage
Done
Structured Logging Migration for Kube...
  
Done
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@aldudko @k8s-ci-robot @ehashman @serathius @dashpole @derekwaynecarr @pacoxu @fejta-bot @dchen1107