Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #96051: Allow priority to be set for kubelet process on Windows hosts #96158

Merged
merged 2 commits into from Dec 4, 2020
Merged

Automated cherry pick of #96051: Allow priority to be set for kubelet process on Windows hosts #96158

merged 2 commits into from Dec 4, 2020

Conversation

ravisantoshgudimetla
Copy link
Contributor

@ravisantoshgudimetla ravisantoshgudimetla commented Nov 3, 2020 •
edited

Cherry pick of #96051 on release-1.18.

#96051: Allow priority to be set for kubelet process on

For details on the cherry pick process, see the cherry pick requests page.

What type of PR is this?
/kind feature

What this PR does / why we need it:
Introduce windows-priorityclass flag to set priority for the kubelet running on Windows nodes

Which issue(s) this PR fixes:

Automated cherry pick of #96051

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Add a new flag to set priority for the kubelet on Windows nodes so that workloads cannot overwhelm the node there by disrupting kubelet process.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Allow user to specify priority of the kubelet process on Windows nodes.

/sig windows
cc @marosset @jsturtevant @derekwaynecarr

@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Nov 3, 2020
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/kubelet labels Nov 3, 2020
@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 3, 2020
@marosset
Copy link
Contributor

marosset commented Nov 3, 2020

Looks like the bazel builds need to be regenerated for this CP.

@spiffxp spiffxp added do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Nov 5, 2020
@ravisantoshgudimetla ravisantoshgudimetla force-pushed the automated-cherry-pick-of-#96051-upstream-release-1.18 branch from bacf7ec to c6c3499 Compare November 9, 2020 04:42
@ravisantoshgudimetla ravisantoshgudimetla force-pushed the automated-cherry-pick-of-#96051-upstream-release-1.18 branch from c6c3499 to 00e64e1 Compare November 9, 2020 05:19
ravisantoshgudimetla
ravisantoshgudimetla commented Nov 9, 2020
View reviewed changes
cmd/kubelet/app/init_windows.go
return fmt.Errorf("unknown priority class %s, valid ones are available at "+
"https://docs.microsoft.com/en-us/windows/win32/procthread/scheduling-priorities", windowsPriorityClass)
}
kubeletProcessHandle, err := windows.GetCurrentProcess()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to use GetCurrentProcess() as CurrentProcess() is not available

@derekwaynecarr
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 9, 2020
@derekwaynecarr
Copy link
Member

/lgtm cancel
/approve cancel

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 9, 2020
@derekwaynecarr
Copy link
Member

why are we backporting features?

@derekwaynecarr
Copy link
Member

see #96157 (comment)

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 16, 2020
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 16, 2020
@ravisantoshgudimetla ravisantoshgudimetla changed the title Automated cherry pick of #96051: Allow priority to be set for kubelet process on Automated cherry pick of #96051: Allow priority to be set for kubelet process on Windows hosts Nov 23, 2020
@ravisantoshgudimetla
Copy link
Contributor Author

@kubernetes/release-managers for cherrypick approvals

1 similar comment
@ravisantoshgudimetla
Copy link
Contributor Author

@kubernetes/release-managers for cherrypick approvals

@cpanato cpanato mentioned this pull request Nov 27, 2020
Merged
@cpanato
Copy link
Member

cpanato commented Dec 4, 2020

/triage accepted

from parent PR
/priority important-soon

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Dec 4, 2020
cpanato
cpanato approved these changes Dec 4, 2020
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, derekwaynecarr, ravisantoshgudimetla

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cpanato cpanato added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Dec 4, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Dec 4, 2020
@cpanato
Copy link
Member

cpanato commented Dec 4, 2020

/triage accepted

from parent PR
/priority important-soon
/kind feature

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Dec 4, 2020
@k8s-ci-robot k8s-ci-robot merged commit 4c00c3c into kubernetes:release-1.18 Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato cpanato approved these changes

@mtaufen mtaufen Awaiting requested review from mtaufen

@yifan-gu yifan-gu Awaiting requested review from yifan-gu

Assignees

@cpanato cpanato

@derekwaynecarr derekwaynecarr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ravisantoshgudimetla @marosset @derekwaynecarr @cpanato @k8s-ci-robot @spiffxp