Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move RootCAConfigMap to ga #98033

Merged
merged 1 commit into from Feb 23, 2021
Merged

move RootCAConfigMap to ga #98033

merged 1 commit into from Feb 23, 2021

Conversation

zshihang
Copy link
Contributor

@zshihang zshihang commented Jan 13, 2021 •
edited

What type of PR is this?

/kind feature

What this PR does / why we need it:
mature RootCAConfigMap in preparation of BoundServiceAccountTokenVolume Beta

feature gate RootCAConfigMap is graduated to GA in 1.21 and will be removed in 1.22.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/tree/master/keps/sig-auth/1205-bound-service-account-tokens

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 13, 2021
@zshihang
Copy link
Contributor Author

/sig auth
/cc @liggitt @mikedanese

@k8s-ci-robot k8s-ci-robot added sig/auth Categorizes an issue or PR as relevant to SIG Auth. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 13, 2021
@zshihang
Copy link
Contributor Author

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 13, 2021
@k8s-ci-robot
Copy link
Contributor

@zshihang: The label(s) priority/high cannot be applied, because the repository doesn't have them

In response to this:

/priority high

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zshihang
Copy link
Contributor Author

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 13, 2021
@dims
Copy link
Member

dims commented Jan 14, 2021

/assign @liggitt @enj

@liggitt
Copy link
Member

liggitt commented Jan 20, 2021

A few additions:

  1. Needs a release note indicating the feature is graduated and the --feature-gate arg will be removed in 1.22
  2. The "should guarantee kube-root-ca.crt exist in any namespace" e2e should be promoted to conformance
  3. Checks of ...Enabled(features.RootCAConfigMap) should be dropped

@liggitt liggitt added this to the v1.21 milestone Jan 20, 2021
@mikedanese mikedanese mentioned this pull request Jan 20, 2021
Closed
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Feb 22, 2021
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/apiserver sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 22, 2021
@zshihang
Copy link
Contributor Author

promoting e2e test to conformance in #99316 and it is approved.

looks like we need to submit this first so that pull-kubernetes-conformance-kind-ga-only-parallel can pass.

@liggitt
Copy link
Member

liggitt commented Feb 23, 2021

/lgtm
/approve

@liggitt
Copy link
Member

liggitt commented Feb 23, 2021

/retest

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 23, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, zshihang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 23, 2021
@k8s-ci-robot k8s-ci-robot merged commit 54d48d2 into kubernetes:master Feb 23, 2021
@liggitt liggitt moved this from In progress to 1.21 - Done in SIG-Auth: Projected Service Account Tokens Feb 23, 2021
@zshihang zshihang mentioned this pull request Mar 16, 2021
Merged
@carlory carlory mentioned this pull request Apr 28, 2021
Merged
@Shubham82 Shubham82 mentioned this pull request Jun 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt Awaiting requested review from liggitt

@mikedanese mikedanese Awaiting requested review from mikedanese

@dims dims Awaiting requested review from dims

@lavalamp lavalamp Awaiting requested review from lavalamp

Assignees

@liggitt liggitt

@enj enj

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG-Auth: Projected Service Account T...
1.21 - Done
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@zshihang @k8s-ci-robot @dims @liggitt @enj