Migrate pkg/kubelet/cm/cpumanage/{topology/togit pology.go, policy_none.go, cpu_assignment.go} to structured logging #100163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
lala123912
force-pushed
the
kubelet_log_3
branch
from
60170c5
to
69d4639
Compare
|
/assign @ConnorDoyle |
k8s-ci-robot
added
the
lgtm
ehashman
added this to Needs Reviewer
in Structured Logging Migration for Kubelet, 1.21
ehashman
reviewed
Mar 12, 2021
| @@ -236,8 +236,7 @@ func Discover(machineInfo *cadvisorapi.MachineInfo) (*CPUTopology, error) { | |||
| } | |||
| } | |||
| } else { | |||
| klog.Errorf("could not get unique coreID for socket: %d core %d threads: %v", | |||
| core.SocketID, core.Id, core.Threads) | |||
| klog.InfoS("Could not get unique coreID for socket", "socket", core.SocketID, "core", core.Id, "threads", core.Threads) | |||
There was a problem hiding this comment.
Suggested change
| klog.InfoS("Could not get unique coreID for socket", "socket", core.SocketID, "core", core.Id, "threads", core.Threads) | |
| klog.ErrorS(nil, "Could not get unique coreID for socket", "socket", core.SocketID, "core", core.Id, "threads", core.Threads) |
There was a problem hiding this comment.
Update to ErrorS.
| @@ -190,7 +190,7 @@ func takeByTopology(topo *topology.CPUTopology, availableCPUs cpuset.CPUSet, num | |||
| // on the same sockets as the whole cores we have already taken in this | |||
| // allocation. | |||
| for _, c := range acc.freeCPUs() { | |||
| klog.V(4).Infof("[cpumanager] takeByTopology: claiming CPU [%d]", c) | |||
| klog.V(4).InfoS("takeByTopology: claiming CPU", "CPU", c) | |||
There was a problem hiding this comment.
Suggested change
| klog.V(4).InfoS("takeByTopology: claiming CPU", "CPU", c) | |
| klog.V(4).InfoS("takeByTopology: claiming CPU", "cpu", c) |
There was a problem hiding this comment.
Use cpu instead now. Could you review it all again, pls?@ehashman
k8s-ci-robot
added
triage/accepted
|
/lgtm cancel because we accidentally turned an Errorf into an InfoS, should be ErrorS |
ehashman
moved this from Needs Reviewer
to Waiting on Author
in Structured Logging Migration for Kubelet, 1.21
k8s-ci-robot
removed
the
lgtm
…o, cpu_assignment.go} to structured logging
lala123912
force-pushed
the
kubelet_log_3
branch
from
69d4639
to
b247240
Compare
shubheksha
reviewed
Mar 15, 2021
| @@ -236,8 +236,7 @@ func Discover(machineInfo *cadvisorapi.MachineInfo) (*CPUTopology, error) { | |||
| } | |||
| } | |||
| } else { | |||
| klog.Errorf("could not get unique coreID for socket: %d core %d threads: %v", | |||
| core.SocketID, core.Id, core.Threads) | |||
| klog.ErrorS(nil, "Could not get unique coreID for socket", "socket", core.SocketID, "core", core.Id, "threads", core.Threads) | |||
There was a problem hiding this comment.
Suggested change
| klog.ErrorS(nil, "Could not get unique coreID for socket", "socket", core.SocketID, "core", core.Id, "threads", core.Threads) | |
| klog.ErrorS(nil, "Could not get unique coreID for socket", "socketID", core.SocketID, "coreID", core.Id, "threads", core.Threads) |
There was a problem hiding this comment.
I don't think this is consistent, we should leave this as is.
k8s-ci-robot
added
the
lgtm
ehashman
moved this from Waiting on Author
to Needs Approver
in Structured Logging Migration for Kubelet, 1.21
mrunalp
approved these changes
Mar 16, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lala123912, mrunalp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
ehashman
moved this from Needs Approver
to Done
in Structured Logging Migration for Kubelet, 1.21
k8s-ci-robot
added
release-note-none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Which issue(s) this PR fixes:
Part of #98976
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
/sig node instrumentation
/priority important-soon