New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate pkg/kubelet/cm/topologymanager to structure logging #99969
Conversation
fa5d4a4
to
21ff9bc
Compare
/triage accepted |
21ff9bc
to
ded9b3a
Compare
b852e31
to
81ca9d7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a user facing change, please update description so this gets a release note. thanks!
81ca9d7
to
d601ddf
Compare
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
caught one thing going thru
d601ddf
to
95db61e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
re-reviewed and all requested changes made. thank you!
/lgtm
/milestone v1.21 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: knabben, mrunalp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
/sig instrumentation
/sig node
What this PR does / why we need it:
Migrate
pkg/kubelet/cm/topologymanager/
Which issue(s) this PR fixes:
Rels #98976
Special notes for your reviewer:
Does this PR introduce a user-facing change?