Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update system-validators to v1.4.0 #98977

Merged
merged 2 commits into from Mar 3, 2021
Merged

update system-validators to v1.4.0 #98977

merged 2 commits into from Mar 3, 2021

Conversation

neolit123
Copy link
Member

@neolit123 neolit123 commented Feb 11, 2021 •
edited

What this PR does / why we need it:

after kubernetes/system-validators#23 merged.
the system-validator library was tagged with v1.4.0 to support Docker 20.10.

  • Update the vendored system-validators to v1.4.0.
  • Bump the Docker version in dependecies.yaml

e2e tests in Kops are already testing this version of Docker:
https://github.com/kubernetes/kops/search?p=2&q=%2220.10%22
https://storage.googleapis.com/kubernetes-jenkins/logs/e2e-kops-grid-calico-flatcar-k20-ko20-docker/1365142370928037888/build-log.txt

and Docker 19.03 will be EOLed in July:
https://endoflife.software/applications/virtualization/docker-daemon

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Update the latest validated version of Docker to 20.10

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 11, 2021
@neolit123
Copy link
Member Author

/milestone v1.21

@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Feb 11, 2021
@neolit123
Copy link
Member Author

/sig node cluster-lifecycle

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 11, 2021
@neolit123
Copy link
Member Author

/priority important-soon
/kind feature
/triage accepted

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 11, 2021
@ehashman ehashman added this to Waiting on Author in SIG Node PR Triage Feb 11, 2021
@pacoxu
Copy link
Member

pacoxu commented Feb 26, 2021

Will we support 20.10 docker in 1.21?

https://endoflife.software/applications/virtualization/docker-daemon
Docker 19.03 will be End Of Life on July 21, 2021.

We may do it before 1.22 release.

@neolit123
Copy link
Member Author

@pacoxu

yep, i was mostly waiting to see if sig node wish to make any modifications to system-validators in 1.21.
if not, we can merge just the docker 20.x bump for 1.21.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 2, 2021
@k8s-ci-robot k8s-ci-robot added area/dependency Issues or PRs related to dependency changes area/kubectl sig/cli Categorizes an issue or PR as relevant to SIG CLI. labels Mar 2, 2021
@neolit123 neolit123 changed the title update system_validators for 1.21 update system-validators to v1.4.0 Mar 2, 2021
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 2, 2021
@neolit123 neolit123 marked this pull request as ready for review March 2, 2021 18:59
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 2, 2021
neolit123
neolit123 commented Mar 2, 2021
View reviewed changes
go.mod Outdated Show resolved Hide resolved
@neolit123
Copy link
Member Author

/test pull-kubernetes-dependencies

@neolit123
Copy link
Member Author

neolit123 commented Mar 2, 2021 •
edited

i ran this again:

./hack/pin-dependency.sh k8s.io/system-validators v1.4.0
./hack/update-vendor.sh

and now the diff does not include the staging / kubectl changes.
could have been some sort of a temporary staging problem.

BenTheElder
BenTheElder reviewed Mar 2, 2021
View reviewed changes
build/dependencies.yaml
@@ -71,7 +71,7 @@ dependencies:

# Docker
- name: "docker"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This entry seems odd / misleading.

  • it's only matching one file
  • it's not really a dependency?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's only matching one file

i guess there are not other places to track this.

it's not really a dependency?

same goes for "crictl" and "cni".

the original idea was to have a machine readable file that can be used by maintainers and users to track what is the latest version of component X that k8s supports. k8s may also depend on component X.

based on that, maybe dependecies.yaml is not the right name.
but renaming it is a breaking change to the same users.

alternatively all those components that k8s actually does not depend on can be removed.
which is also a breaking change.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess, we do actually require a minimum docker version for other reasons (building) that we ought to be tracking but that's a separate concern, and this will go away anyhow when dockershim goes away.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and this will go away anyhow when dockershim goes away.

instead i recall discussions to add containerd in this file too, to let users know what is the latest version we are testing.
cc @dims

@k8s-ci-robot
Copy link
Contributor

@neolit123: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubernetes-e2e-azure-disk-windows b03418c link /test pull-kubernetes-e2e-azure-disk-windows

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@BenTheElder
Copy link
Member

/lgtm
/approve
/skip

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 2, 2021
@neolit123
Copy link
Member Author

/assign @liggitt
PTAL for go.mod approval.

@liggitt
Copy link
Member

liggitt commented Mar 3, 2021

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, liggitt, neolit123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 3, 2021
@k8s-ci-robot k8s-ci-robot merged commit 2695ef3 into kubernetes:master Mar 3, 2021
SIG Node PR Triage automation moved this from Waiting on Author to Done Mar 3, 2021
@neolit123 neolit123 mentioned this pull request Mar 9, 2021
Merged
@neolit123 neolit123 mentioned this pull request Jun 26, 2021
Merged
@neolit123 neolit123 mentioned this pull request Aug 9, 2021
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder BenTheElder left review comments

@justaugustus justaugustus Awaiting requested review from justaugustus

@saschagrunert saschagrunert Awaiting requested review from saschagrunert

Assignees

@BenTheElder BenTheElder

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/node Categorizes an issue or PR as relevant to SIG Node. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node PR Triage
Done
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@neolit123 @k8s-ci-robot @pacoxu @BenTheElder @liggitt