Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[kubelet metrics] Readjust kubelet_containers_per_pod_count bucket #98169

Merged
merged 1 commit into from Jan 19, 2021
Merged

[kubelet metrics] Readjust kubelet_containers_per_pod_count bucket #98169

merged 1 commit into from Jan 19, 2021

Conversation

wawa0210
Copy link
Contributor

@wawa0210 wawa0210 commented Jan 19, 2021 •
edited

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #98167

Special notes for your reviewer:
The container in the pod is not less than 1, so adjust the bucket to make it more in line with the real scene

Does this PR introduce a user-facing change?:

readjust kubelet_containers_per_pod_count bucket

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/sig node
/area kubelet

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 19, 2021
@wawa0210
Copy link
Contributor Author

/assign @dashpole

@k8s-ci-robot k8s-ci-robot added area/kubelet sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 19, 2021
@wawa0210
Copy link
Contributor Author

/test pull-kubernetes-integration

@dashpole
Copy link
Contributor

/lgtm
/approve

@dashpole
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 19, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dashpole, wawa0210

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 19, 2021
@k8s-ci-robot k8s-ci-robot merged commit a410c14 into kubernetes:master Jan 19, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Jan 19, 2021
@wawa0210 wawa0210 deleted the fix-98167 branch January 19, 2021 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehashman ehashman Awaiting requested review from ehashman

@odinuge odinuge Awaiting requested review from odinuge

Assignees

@dashpole dashpole

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

[kubelet metrics] kubelet_containers_per_pod_count_bucket optimization, buckets smaller than 1 are meaningless
3 participants
@wawa0210 @dashpole @k8s-ci-robot