Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated --seccomp-profile-root/seccompProfileRoot config #103941

Merged
merged 1 commit into from Sep 2, 2021
Merged

Remove deprecated --seccomp-profile-root/seccompProfileRoot config #103941

merged 1 commit into from Sep 2, 2021

Conversation

saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Jul 27, 2021 •
edited

What type of PR is this?

/kind api-change

What this PR does / why we need it:

The configuration is deprecated and targets removal for v1.23. Tests cases have been changed as well.

Which issue(s) this PR fixes:

Follow-up of #91182
Refers to kubernetes/enhancements#135

Special notes for your reviewer:

cc @knabben @pjbgf

/milestone v1.23

Does this PR introduce a user-facing change?

Removed deprecated `--seccomp-profile-root`/`seccompProfileRoot` config

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- KEP: https://github.com/kubernetes/enhancements/tree/master/keps/sig-node/135-seccomp#seccomp-root-path-configuration

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 27, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Jul 27, 2021
@k8s-ci-robot k8s-ci-robot added do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Jul 27, 2021
@saschagrunert
Copy link
Member Author

/priority important-soon
/sig node

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/node Categorizes an issue or PR as relevant to SIG Node. area/kubelet and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 27, 2021
@saschagrunert
Copy link
Member Author

/retest

@knabben
Copy link
Member

knabben commented Jul 27, 2021

/lgtm

Thanks for handling this one @saschagrunert

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 27, 2021
@knabben
Copy link
Member

knabben commented Jul 27, 2021

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 27, 2021
@k8s-triage-robot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

pjbgf
pjbgf approved these changes Jul 28, 2021
View reviewed changes
Copy link
Member

@pjbgf pjbgf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@pjbgf
Copy link
Member

pjbgf commented Jul 29, 2021

/assign @dchen1107 @erictune

@ehashman ehashman added this to Triage in SIG Node PR Triage Aug 2, 2021
@ehashman ehashman moved this from Triage to Needs Approver in SIG Node PR Triage Aug 2, 2021
@mrunalp
Copy link
Contributor

mrunalp commented Aug 24, 2021

/approve

@mrunalp mrunalp moved this from Needs Approver to Done in SIG Node PR Triage Aug 24, 2021
@saschagrunert
Copy link
Member Author

@kubernetes/api-approvers PTAL

liggitt
liggitt reviewed Aug 30, 2021
View reviewed changes
pkg/kubelet/kuberuntime/helpers.go Outdated
@@ -266,6 +266,11 @@ func (m *kubeGenericRuntimeManager) getSeccompProfilePath(annotations map[string
return ""
}

// seccompRootDirectory returns the path for the localhost seccomp profiles.
func (m *kubeGenericRuntimeManager) seccompRootDirectory() string {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how frequently is this called? would it make sense to construct this once at startup? xref #16384 for cost of invoking Join methods repeatedly.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I moved the construction of this path to the kuberuntime initialization: https://github.com/kubernetes/kubernetes/pull/103941/files#diff-0e1a8d22b0f1dc42d412749c6a916b4c76394ead739d4bfbf26564faedd74a2fR210

@liggitt
Copy link
Member

liggitt commented Aug 30, 2021

api doc change and flag bit lgtm, a couple questions about the implementation

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 31, 2021
@saschagrunert
Remove deprecated --seccomp-profile-root/seccompProfileRoot confi…
46077e6 
…guration

The configuration is deprecated and targets removal for v1.23. Tests
cases have been changed as well.

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@liggitt
Copy link
Member

liggitt commented Sep 2, 2021

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 2, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, mrunalp, pjbgf, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 2, 2021
@k8s-ci-robot k8s-ci-robot merged commit 0b4a793 into kubernetes:master Sep 2, 2021
@saschagrunert saschagrunert deleted the seccomp-profile-root branch September 2, 2021 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@pjbgf pjbgf pjbgf approved these changes

@feiskyer feiskyer Awaiting requested review from feiskyer

@mwielgus mwielgus Awaiting requested review from mwielgus

Assignees

@liggitt liggitt

@knabben knabben

@pjbgf pjbgf

@dchen1107 dchen1107

@erictune erictune

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node PR Triage
Done
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@saschagrunert @knabben @k8s-triage-robot @pjbgf @mrunalp @liggitt @k8s-ci-robot @dchen1107 @erictune