New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support M1 MacBooks darwin/arm64 on the client-side #97743
Support M1 MacBooks darwin/arm64 on the client-side #97743
Conversation
/sig release @kubernetes/release-managers WDYT? what else do we need? |
/hold |
@dims we are going to be working on formalizing the process for supported platforms in the 1.21 cycle (kubernetes/sig-release#1337). This, along with riscv, would be a good candidate to be the pilots for this process. What do you think? |
@hasheddan +1 sounds good! |
/lgtm |
we'll need to wait for golang 1.16 ... forgot to mention :) |
/lgtm cancel |
f95165b
to
649b2aa
Compare
For good measure, I'll also include the output from
|
@endocrimes thanks! would you be able to verify that say |
Passed on Docker for Mac 3.1.0, Mini M1 11.2.2 🎉 Go and Docker versions
|
@dims here you go!
Update: |
@endocrimes thanks! /meowvie thanks |
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Worked fine for me! 🎉 |
Hello! I am from the Bug Triage team! Friendly reminder that code freeze is starting March 9th, 2021 (about 1 week from now). We want to ensure that each PR has a chance to be merged before code freeze. This looks like its close to being approved and merged but still commenting for awareness 😄 |
Just FYI--I got my M1 before the end of 2020 and had a fairly hacked up environment (brew under Rosetta and hadn't updated to the M1-enabled To get the changes in this PR to work I had to undo my arch hackiness (which I've needed to for awhile, so thanks for forcing my hand @dims! 😂 ) and make sure I was running fully under
|
woohoo @estesp ! |
@dims see: #97743 (comment) |
@BenTheElder sorry missed it. responded there |
/lgtm |
/test pull-kubernetes-cross |
/test pull-kubernetes-e2e-kind |
✨ 🚀 💖 |
Thanks everyone for helping with testing this! @endocrimes @estesp @stevesloka @pires @alenkacz @ghuntley (apologies if i missed anyone!) |
This was super interesting to follow. I managed to build kubectl from source and it works like a charm 🔥 |
for those who end up coming here ... if you need just kubectl ... you don't need to build the full release. just do:
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder, dims, headcr4sh, justaugustus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Please test using:
Signed-off-by: Davanum Srinivas davanum@gmail.com
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #97550
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: