New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove --cleanup-ipvs flag of kube-proxy #97336
Conversation
Hi @maaoBit. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc @aojea |
pkg/proxy/ipvs/proxier.go
Outdated
return true | ||
} | ||
encounteredError = false | ||
err := ipvs.Flush() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is probably fine but just confirming, this flushes all IPVS rules, not just the Kubernetes managed ones right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, this clears all ipvs rules
pkg/proxy/ipvs/proxier.go
Outdated
func CleanupLeftovers(ipvs utilipvs.Interface, ipt utiliptables.Interface, ipset utilipset.Interface) (encounteredError bool) { | ||
// Return immediately when ipvs interface is nil - Probably initialization failed in somewhere. | ||
if ipvs == nil { | ||
return true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if IPVS is nil we probably want to still run the iptables clean up, so maybe this should be:
if ipvs != nil {
// IPVS clean up
}
// rest of the function..
/kind bug |
/triage accepted |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
pkg/proxy/ipvs/proxier.go
Outdated
err := ipvs.Flush() | ||
if err != nil { | ||
klog.Errorf("Error flushing IPVS rules: %v", err) | ||
encounteredError = true | ||
} | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need extra space.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Has been modified, PTAL
Signed-off-by: maao <maao420691301@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
Thanks @maaoBit
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrewsykim, maaoBit The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: maao maao420691301@gmail.com
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #96034
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: