Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GracefulNodeShutdown configuration remove executable permission bits #97950

Merged
merged 1 commit into from Jan 13, 2021
Merged

GracefulNodeShutdown configuration remove executable permission bits #97950

merged 1 commit into from Jan 13, 2021

Conversation

wzshiming
Copy link
Member

@wzshiming wzshiming commented Jan 12, 2021 •
edited by liggitt

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #97949

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 12, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @wzshiming. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 12, 2021
@wzshiming wzshiming changed the title remove executable permission bits GracefulNodeShutdown configuration remove executable permission bits Jan 12, 2021
odinuge
odinuge approved these changes Jan 12, 2021
View reviewed changes
Copy link
Member

@odinuge odinuge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, and thanks for the patch!

/triage accepted
/lgtm
/ok-to-test
/priority backlog

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 12, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 12, 2021
@pacoxu
Copy link
Member

pacoxu commented Jan 12, 2021

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 12, 2021
@ehashman ehashman added this to Needs Reviewer in SIG Node PR Triage Jan 12, 2021
@ehashman
Copy link
Member

/lgtm

@ehashman ehashman moved this from Needs Reviewer to Needs Approver in SIG Node PR Triage Jan 12, 2021
@bobbypage
Copy link
Member

Thanks for the fix!

/lgtm

@bobbypage
Copy link
Member

bobbypage commented Jan 12, 2021 •
edited

/assign @mrunalp

@mrunalp
Copy link
Contributor

mrunalp commented Jan 12, 2021

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrunalp, odinuge, wzshiming

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 12, 2021
@ehashman
Copy link
Member

/test pull-kubernetes-integration

@k8s-ci-robot k8s-ci-robot merged commit 47ccae1 into kubernetes:master Jan 13, 2021
SIG Node PR Triage automation moved this from Needs Approver to Done Jan 13, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Jan 13, 2021
@ehashman ehashman mentioned this pull request Jan 13, 2021
Merged
13 tasks
@wzshiming wzshiming deleted the fix-executable-permission branch January 23, 2021 06:25
@wzshiming wzshiming mentioned this pull request Jan 25, 2021
Closed
6 tasks
@SergeyKanzhelev SergeyKanzhelev mentioned this pull request Feb 20, 2021
Merged
@wzshiming wzshiming mentioned this pull request Feb 20, 2021
Merged
jingxu97 pushed a commit to jingxu97/kubernetes that referenced this pull request Mar 2, 2021
@wzshiming
kubelet:shutdown remove executable permission bits
3e67aa9 
Cherrypicking kubernetes#97950 from upstream

kubernetes#97950

Change-Id: I0e7fa946a395245feeaf19fce57e3c920dc007a4
k8s-ci-robot added a commit that referenced this pull request Mar 11, 2021
@k8s-ci-robot
Merge pull request #99253 from wzshiming/automated-cherry-pick-of-#97…
2826326 
…950-upstream-release-1.20

Automated cherry pick of #97950: remove executable permission bits
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odinuge odinuge odinuge approved these changes

@mtaufen mtaufen Awaiting requested review from mtaufen

Assignees

@mrunalp mrunalp

@bobbypage bobbypage

@odinuge odinuge

@pacoxu pacoxu

@ehashman ehashman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node PR Triage
Done
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

GracefulNodeShutdown configuration file /etc/systemd/logind.conf.d/99-kubelet.conf is marked executable.
7 participants
@wzshiming @k8s-ci-robot @pacoxu @ehashman @bobbypage @mrunalp @odinuge