Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fluentd/elasticsearch] Add mechanism to load simple sniffer class #92853

Merged
merged 1 commit into from Sep 24, 2021
Merged

[fluentd/elasticsearch] Add mechanism to load simple sniffer class #92853

merged 1 commit into from Sep 24, 2021

Conversation

cosmo0920
Copy link
Contributor

Signed-off-by: Hiroshi Hatake cosmo0920.oucc@gmail.com

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind api-change
/kind bug
/kind cleanup
/kind deprecation
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

We'd received that fluentd which is deployed with fluentd-elasticsearch stable chart sometimes exhausted due to elasticsearch ruby client sniffering issue.
This issue should be fixed in fluent-plugin-elasticsearch repository: uken/fluent-plugin-elasticsearch#459
But this feature requests to add additional load command for simple sniffer class which is bundled in fluent-plugin-elasticsearch.

Which issue(s) this PR fixes:

Fixes #92852

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Add mechanism to load simple sniffer class into fluentd-elasticsearch image

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 7, 2020
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 7, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @cosmo0920!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 7, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @cosmo0920. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added area/provider/gcp Issues or PRs related to gcp provider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 7, 2020
@cosmo0920 cosmo0920 force-pushed the add-sniffer-class-loading-feature-on-es-image branch 3 times, most recently from 432249a to 21d79c7 Compare July 7, 2020 03:53
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 7, 2020
@cosmo0920 cosmo0920 changed the title fluentd-elasticsearch: Add mechanism to load simple sniffer class [fluentd/elasticsearch] Add mechanism to load simple sniffer class Jul 7, 2020
@logicalhan
Copy link
Member

/assign

@spiffxp spiffxp added do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Nov 5, 2020
@andrewsykim
Copy link
Member

/assign @cheftako

@cheftako
Copy link
Member

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 12, 2020
@cosmo0920
Copy link
Contributor Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 25, 2021
@BenTheElder
Copy link
Member

/retest
[pull-kubernetes-unit: new job, not yet blocking, fixed the config, nothing to see here!]

@cosmo0920
Copy link
Contributor Author

/retest

1 similar comment
@cosmo0920
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 25, 2021
@cosmo0920
Copy link
Contributor Author

/retest

@cosmo0920 cosmo0920 force-pushed the add-sniffer-class-loading-feature-on-es-image branch from 98be87e to bf9f019 Compare March 1, 2021 02:03
@cosmo0920
Copy link
Contributor Author

/retest

@cosmo0920
Copy link
Contributor Author

Unit tests are passed. What should I do next?

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 30, 2021
@cosmo0920
Copy link
Contributor Author

/retest
[pull-kubernetes-unit: new job, not yet blocking, fixed the config, nothing to see here!]

@cosmo0920
Copy link
Contributor Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 31, 2021
@cosmo0920
Copy link
Contributor Author

cosmo0920 commented Aug 19, 2021 •
edited

@coffeepac @monotek @logicalhan You guys could review this PR? I'm struggling why this PR isn't merged yet and w/o this patch, ES plugin must be stuck after 10000 request events ingestion. This could be definitely useless for heavily deployed containers/working a lot of containers environment.

Official Fluentd daemonset supported this feature for a long time ago:
https://github.com/fluent/fluentd-kubernetes-daemonset/blob/master/templates/entrypoint.sh.erb#L11-L15

But gcr.io images are still not supported yet.
And this issue often reported in fluent-plugin-elasticsearch repo but this issue definitely cannot handle in Fluentd ES plugin repo.

monotek
monotek approved these changes Aug 19, 2021
View reviewed changes
Copy link
Member

@monotek monotek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 19, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cosmo0920, monotek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 19, 2021
@monotek
Copy link
Member

monotek commented Sep 21, 2021

@cheftako @BenTheElder can we remove the hold?

@cheftako
Copy link
Member

/remove hold

@cheftako
Copy link
Member

/remove-hold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 24, 2021
@k8s-ci-robot k8s-ci-robot merged commit 7bff8ad into kubernetes:master Sep 24, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Sep 24, 2021
@cosmo0920 cosmo0920 deleted the add-sniffer-class-loading-feature-on-es-image branch September 24, 2021 07:11
@cosmo0920
Copy link
Contributor Author

🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monotek monotek monotek approved these changes

@kawych kawych Awaiting requested review from kawych

@logicalhan logicalhan Awaiting requested review from logicalhan

Assignees

@logicalhan logicalhan

@cheftako cheftako

@monotek monotek

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/gcp Issues or PRs related to gcp provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

fluentd-elasticsearch image should load simple sniffer class
9 participants
@cosmo0920 @k8s-ci-robot @logicalhan @andrewsykim @cheftako @fejta-bot @BenTheElder @monotek @spiffxp