New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable goaway testcases #98809
enable goaway testcases #98809
Conversation
/ok-to-test |
/test pull-kubernetes-verify-govet-levee |
/assign @caesarxuchao |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for looking into this flake!
@@ -438,10 +436,8 @@ func TestGOAWAYHTTP1Requests(t *testing.T) { | |||
} | |||
|
|||
// TestGOAWAYConcurrency tests GOAWAY frame will not affect concurrency requests in a single http client instance. | |||
// Known issues in history: https://github.com/kubernetes/kubernetes/issues/91131. | |||
// Known issues in history: https://github.com/kubernetes/kubernetes/issues/91131, https://github.com/golang/go/issues/41234. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that the flake is fixed, we don't need to record history in the comment anymore. Can you remove this line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Already done, thanks
….org/x/net version.
069e142
to
f1b23fe
Compare
/test pull-kubernetes-e2e-kind Kubernetes e2e suite: [k8s.io] Probing container should not be ready until startupProbe succeeds
Kubernetes e2e suite: [k8s.io] [sig-node] RuntimeClass should run a Pod requesting a RuntimeClass with scheduling without taints |
e2e failed again with different cases: Kubernetes e2e suite: [sig-apps] Deployment iterative rollouts should eventually progress
Kubernetes e2e suite: [sig-network] Proxy version v1 A set of valid responses are returned for both pod and service ProxyWithPath [Conformance] /test pull-kubernetes-e2e-kind |
Could you please take another look? |
/lgtm |
/assign @deads2k for approval. Thanks. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: answer1991, caesarxuchao, lavalamp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/test pull-kubernetes-e2e-gce-ubuntu-containerd |
the tests enabled here started flaking again immediately |
What type of PR is this?
/kind flake
What this PR does / why we need it:
After we upgraded golang.org/x/net to latest version, goaway testcases will not flake.
Which issue(s) this PR fixes:
Fixes #94532
Fixes #94622
Special notes for your reviewer:
Apiserver's clients in k/k repo use golang.org/x/net/http2 to config http2 transports instead of use golang SDK h2_bundle. A new version of golang.org/x/net(with golang/net@ff519b6) will fix HTTP2 un-expected error when received GOAWAY frame.
For other clients which use default http2 configuration in golang SDK, golang 1.15.8 or 1.16+ required to avoid HTTP2 un-expected error when received GOAWAY frame.
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: