Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable goaway testcases #98809

Merged
merged 1 commit into from Mar 9, 2021
Merged

enable goaway testcases #98809

merged 1 commit into from Mar 9, 2021

Conversation

answer1991
Copy link
Contributor

What type of PR is this?

/kind flake

What this PR does / why we need it:

After we upgraded golang.org/x/net to latest version, goaway testcases will not flake.

Which issue(s) this PR fixes:

Fixes #94532
Fixes #94622

Special notes for your reviewer:

Apiserver's clients in k/k repo use golang.org/x/net/http2 to config http2 transports instead of use golang SDK h2_bundle. A new version of golang.org/x/net(with golang/net@ff519b6) will fix HTTP2 un-expected error when received GOAWAY frame.

For other clients which use default http2 configuration in golang SDK, golang 1.15.8 or 1.16+ required to avoid HTTP2 un-expected error when received GOAWAY frame.

Does this PR introduce a user-facing change?:

If kube-apiserver enabled goaway feature, clients required golang 1.15.8 or 1.16+ version to avoid un-expected data race issue.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/flake Categorizes issue or PR as related to a flaky test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/apiserver sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 5, 2021
@answer1991
Copy link
Contributor Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Feb 5, 2021
@answer1991
Copy link
Contributor Author

cc @liggitt @lavalamp @deads2k

@answer1991 answer1991 changed the title enable goaway testcases which will not flake any more with new golang.org/x/net version enable goaway testcases Feb 7, 2021
@answer1991
Copy link
Contributor Author

/test pull-kubernetes-verify-govet-levee

@answer1991 answer1991 mentioned this pull request Feb 9, 2021
Closed
@jpbetz
Copy link
Contributor

jpbetz commented Feb 9, 2021

/assign @caesarxuchao
/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 9, 2021
caesarxuchao
caesarxuchao reviewed Feb 23, 2021
View reviewed changes
Copy link
Member

@caesarxuchao caesarxuchao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this flake!

staging/src/k8s.io/apiserver/pkg/server/filters/goaway_test.go Outdated
@@ -438,10 +436,8 @@ func TestGOAWAYHTTP1Requests(t *testing.T) {
}

// TestGOAWAYConcurrency tests GOAWAY frame will not affect concurrency requests in a single http client instance.
// Known issues in history: https://github.com/kubernetes/kubernetes/issues/91131.
// Known issues in history: https://github.com/kubernetes/kubernetes/issues/91131, https://github.com/golang/go/issues/41234.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that the flake is fixed, we don't need to record history in the comment anymore. Can you remove this line?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already done, thanks

@answer1991
Copy link
Contributor Author

/test pull-kubernetes-e2e-kind

failed e2e job:

Kubernetes e2e suite: [k8s.io] Probing container should not be ready until startupProbe succeeds
Kubernetes e2e suite: [k8s.io] [sig-node] RuntimeClass should run a Pod requesting a RuntimeClass with scheduling without taints

@answer1991
Copy link
Contributor Author

e2e failed again with different cases:

Kubernetes e2e suite: [sig-apps] Deployment iterative rollouts should eventually progress 
Kubernetes e2e suite: [sig-network] Proxy version v1 A set of valid responses are returned for both pod and service ProxyWithPath [Conformance]

/test pull-kubernetes-e2e-kind

@answer1991
Copy link
Contributor Author

@caesarxuchao

Could you please take another look?

@caesarxuchao
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 8, 2021
@caesarxuchao
Copy link
Member

/assign @deads2k for approval. Thanks.

@lavalamp
Copy link
Member

lavalamp commented Mar 9, 2021

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: answer1991, caesarxuchao, lavalamp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 9, 2021
@caesarxuchao caesarxuchao mentioned this pull request Mar 9, 2021
Closed
@chymy
Copy link
Contributor

chymy commented Mar 9, 2021

/retest

@chymy
Copy link
Contributor

chymy commented Mar 9, 2021

/test pull-kubernetes-e2e-gce-ubuntu-containerd

@k8s-ci-robot k8s-ci-robot merged commit a27a6e7 into kubernetes:master Mar 9, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Mar 9, 2021
@liggitt
Copy link
Member

liggitt commented Mar 11, 2021

the tests enabled here started flaking again immediately

@liggitt liggitt mentioned this pull request Mar 11, 2021
Closed
@answer1991
Copy link
Contributor Author

Looks like #94532 will not flake any more. However, #94622 still has some problem, and I'm working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caesarxuchao caesarxuchao caesarxuchao left review comments

@dims dims Awaiting requested review from dims

@sttts sttts Awaiting requested review from sttts

Assignees

@caesarxuchao caesarxuchao

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/flake Categorizes issue or PR as related to a flaky test. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

TestClientReceivedGOAWAY flakes TestGOAWAYConcurrency fails with data race issues
7 participants
@answer1991 @jpbetz @caesarxuchao @lavalamp @k8s-ci-robot @chymy @liggitt